Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

Note that all of the members are properly initialized a few lines
above the constructor.

Note that all of the members are properly initialized a few lines
above the constructor.
@llvmbot llvmbot added mlgo llvm:analysis Includes value tracking, cost tables and constant folding labels Oct 28, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 28, 2025

@llvm/pr-subscribers-mlgo

@llvm/pr-subscribers-llvm-analysis

Author: Kazu Hirata (kazutakahirata)

Changes

Note that all of the members are properly initialized a few lines
above the constructor.


Full diff: https://github.com/llvm/llvm-project/pull/165395.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Analysis/IR2Vec.h (+1-1)
diff --git a/llvm/include/llvm/Analysis/IR2Vec.h b/llvm/include/llvm/Analysis/IR2Vec.h
index 5ad62880a779c..71055dd16a378 100644
--- a/llvm/include/llvm/Analysis/IR2Vec.h
+++ b/llvm/include/llvm/Analysis/IR2Vec.h
@@ -161,7 +161,7 @@ class VocabStorage {
 
 public:
   /// Default constructor creates empty storage (invalid state)
-  VocabStorage() : Sections(), TotalSize(0), Dimension(0) {}
+  VocabStorage() = default;
 
   /// Create a VocabStorage with pre-organized section data
   VocabStorage(std::vector<std::vector<Embedding>> &&SectionData);

@mtrofin mtrofin requested a review from svkeerthy October 28, 2025 14:26
@kazutakahirata kazutakahirata merged commit 75ddf2a into llvm:main Oct 28, 2025
13 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20251027_Analysys_VocabStorage_default branch October 28, 2025 23:16
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
Note that all of the members are properly initialized a few lines
above the constructor.
DEBADRIBASAK pushed a commit to DEBADRIBASAK/llvm-project that referenced this pull request Nov 3, 2025
Note that all of the members are properly initialized a few lines
above the constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm:analysis Includes value tracking, cost tables and constant folding mlgo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants