Skip to content

[mlir][linalg] Do not set insertion point inside padding function #165420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

[mlir][linalg] Do not set insertion point inside padding function #165420

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2440ca6
[mlir][linalg] Do not set insertion point inside padding function
Groverkss Oct 28, 2025
83138cc
Address comments
Groverkss Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions mlir/lib/Dialect/Linalg/Transforms/PadTilingInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,6 @@ FailureOr<PadTilingInterfaceResult> linalg::rewriteAsPaddedOp(
return failure();
}

OpBuilder::InsertionGuard g(builder);
// Set IP after toPad because we also take the dims of toPad's output.
builder.setInsertionPointAfter(toPad);

// 1. Get the loopUpperBounds from the TilingInterface.
SmallVector<Range> iterationDomain = toPad.getIterationDomain(builder);

Expand Down
Loading