Skip to content

[clang][openmp] Fixing Issue-162243 #165562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ritanya-B-Bharadwaj wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[clang][openmp] Fixing Issue-162243 #165562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c62f541
Fixing Issue-162243
Ritanya-B-Bharadwaj Oct 29, 2025
8d34ec1
Adding test case
Ritanya-B-Bharadwaj Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/Sema/SemaOpenMP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3286,7 +3286,7 @@ SemaOpenMP::ActOnOpenMPGroupPrivateDirective(SourceLocation Loc,
ArrayRef<Expr *> VarList) {
if (!getLangOpts().OpenMP || getLangOpts().OpenMP < 60) {
Diag(Loc, diag::err_omp_unexpected_directive)
<< getOpenMPDirectiveName(OMPD_groupprivate, getLangOpts().OpenMP);
<< 1 << getOpenMPDirectiveName(OMPD_groupprivate, getLangOpts().OpenMP);
return nullptr;
}
if (OMPGroupPrivateDecl *D = CheckOMPGroupPrivateDecl(Loc, VarList)) {
Expand Down
1 change: 1 addition & 0 deletions clang/test/OpenMP/groupprivate_messages.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#pragma omp groupprivate( // expected-error {{expected identifier}} expected-error {{expected ')'}} expected-note {{to match this '('}}
#pragma omp groupprivate() // expected-error {{expected identifier}}
#pragma omp groupprivate(1) // expected-error {{expected unqualified-id}}
#pragma omp groupprivate(a) // expected-error {{use of undeclared identifier 'a'}}
Copy link
Member

@alexey-bataev alexey-bataev Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it test the bug?

Copy link
Contributor Author

@Ritanya-B-Bharadwaj Ritanya-B-Bharadwaj Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crash was reported for the same line of code

struct CompleteSt{
int a;
};
Expand Down