Skip to content

Conversation

@JDevlieghere
Copy link
Member

GitHub allows specifying custom instructions for the GitHub Copilot reviewer [1]. Currently, we have a top level file, but GitHub supports having different instructions for different files, which requires creating an instructions subdirectory with multiple files and a patch it applies to.

This PR moves the top level file into a new instructions directory, and make it apply to the llvm/ subdirectory. I spoke with Mircea at the Dev Meeting and that should match his original intent.

[1] https://docs.github.com/en/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review#customizing-copilots-reviews-with-custom-instructions

GitHub allows specifying custom instructions for the GitHub Copilot
reviewer [1]. Currently, we have a top level file, but GitHub supports
having different instructions for different files, which requires
creating an `instructions` subdirectory with multiple files and a patch
it applies to.

This PR moves the top level file into a new `instructions` directory,
and make it apply to the `llvm/` subdirectory. I spoke with Mircea at
the Dev Meeting and that should match his original intent.

[1] https://docs.github.com/en/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review#customizing-copilots-reviews-with-custom-instructions
@JDevlieghere JDevlieghere enabled auto-merge (squash) October 30, 2025 20:23
@JDevlieghere JDevlieghere disabled auto-merge October 30, 2025 21:17
@JDevlieghere JDevlieghere merged commit 4174429 into llvm:main Oct 30, 2025
11 of 12 checks passed
@JDevlieghere JDevlieghere deleted the copilot-instructions branch October 30, 2025 21:17
luciechoi pushed a commit to luciechoi/llvm-project that referenced this pull request Nov 1, 2025
GitHub allows specifying custom instructions for the GitHub Copilot
reviewer [1]. Currently, we have a top level file, but GitHub supports
having different instructions for different files, which requires
creating an `instructions` subdirectory with multiple files and a patch
it applies to.

This PR moves the top level file into a new `instructions` directory,
and make it apply to the `llvm/` subdirectory. I spoke with Mircea at
the Dev Meeting and that should match his original intent.

[1]
https://docs.github.com/en/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review#customizing-copilots-reviews-with-custom-instructions
DEBADRIBASAK pushed a commit to DEBADRIBASAK/llvm-project that referenced this pull request Nov 3, 2025
GitHub allows specifying custom instructions for the GitHub Copilot
reviewer [1]. Currently, we have a top level file, but GitHub supports
having different instructions for different files, which requires
creating an `instructions` subdirectory with multiple files and a patch
it applies to.

This PR moves the top level file into a new `instructions` directory,
and make it apply to the `llvm/` subdirectory. I spoke with Mircea at
the Dev Meeting and that should match his original intent.

[1]
https://docs.github.com/en/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review#customizing-copilots-reviews-with-custom-instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants