Skip to content

[LLDB][DWARF] Use the same qualified name computation for Rust #165840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+1,262 −2
Open

[LLDB][DWARF] Use the same qualified name computation for Rust #165840

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d18b17
[LLDB][DWARF] Use the same qualified name computation for Rust
imkiva Oct 31, 2025
f7d2b1d
[LLDB][DWARF] Address reviews
imkiva Oct 31, 2025
542ce3f
[LLDB][DWARF] add tests code from original issue
imkiva Oct 31, 2025
c744c51
[LLDB][DWARF] format code
imkiva Oct 31, 2025
8a535e9
[LLDB][DWARF] reviews
imkiva Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lldb/include/lldb/Target/Language.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,8 @@ class Language : public PluginInterface {

static bool LanguageIsC(lldb::LanguageType language);

static bool LanguageIsRust(lldb::LanguageType language);

/// Equivalent to \c LanguageIsC||LanguageIsObjC||LanguageIsCPlusPlus.
static bool LanguageIsCFamily(lldb::LanguageType language);

Expand Down
6 changes: 5 additions & 1 deletion lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1700,7 +1700,11 @@ void DWARFASTParserClang::GetUniqueTypeNameAndDeclaration(
// For C++, we rely solely upon the one definition rule that says
// only one thing can exist at a given decl context. We ignore the
// file and line that things are declared on.
if (!die.IsValid() || !Language::LanguageIsCPlusPlus(language) ||
// For Rust, we do the same since Rust also has a similar qualified name?
// Is there a better way to do this for Rust?
Copy link
Member

@Michael137 Michael137 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would reword this to something like:
"FIXME: Rust pretends to be C++ for now, so use C++ name qualification rules"

if (!die.IsValid() ||
(!Language::LanguageIsCPlusPlus(language) &&
Copy link
Member

@Michael137 Michael137 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we split the language check into a separate if-statement? Makes it easier to read

!Language::LanguageIsRust(language)) ||
unique_typename.IsEmpty())
return;
decl_declaration.Clear();
Expand Down
4 changes: 4 additions & 0 deletions lldb/source/Target/Language.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,10 @@ bool Language::LanguageIsCPlusPlus(LanguageType language) {
}
}

bool Language::LanguageIsRust(LanguageType language) {
return language == eLanguageTypeRust;
Copy link
Member

@Michael137 Michael137 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove this API and just check the language type directly at the callsite for now

Copy link
Member

@Michael137 Michael137 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe eventually we'd want something like a "PretendsToBeCxx" API, which is true for rust and couple other languages. But that's out of scope

}

bool Language::LanguageIsObjC(LanguageType language) {
switch (language) {
case eLanguageTypeObjC:
Expand Down
Loading