Skip to content

[libc] Add faccessat entrypoints for aarch64 and riscv #165869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
+19 −2
Merged

[libc] Add faccessat entrypoints for aarch64 and riscv #165869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af59a3c
Add faccessat entrypoints for aarch64 and riscv linux
mleleszi Oct 31, 2025
f0ac60e
Add logging
mleleszi Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions libc/config/linux/aarch64/entrypoints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.unistd.dup2
libc.src.unistd.dup3
libc.src.unistd.execve
# Disabled while SYS_faccessat2 is unavailable on the buildbot.
# libc.src.unistd.faccessat
libc.src.unistd.faccessat
libc.src.unistd.fchdir
libc.src.unistd.fpathconf
libc.src.unistd.fsync
Expand Down
8 changes: 8 additions & 0 deletions libc/config/linux/aarch64/exclude.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
include(CheckSymbolExists)
check_symbol_exists(SYS_faccessat2 "sys/syscall.h" HAVE_SYS_FACCESSAT2)
if(NOT HAVE_SYS_FACCESSAT2)
message(VERBOSE "unistd.faccessat excluded from build, faccessat2 syscall is not available on the system")
list(APPEND TARGET_LLVMLIBC_REMOVED_ENTRYPOINTS
libc.src.unistd.faccessat
)
endif()
1 change: 1 addition & 0 deletions libc/config/linux/riscv/entrypoints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.unistd.dup2
libc.src.unistd.dup3
libc.src.unistd.execve
libc.src.unistd.faccessat
libc.src.unistd.fchdir
libc.src.unistd.fpathconf
libc.src.unistd.fsync
Expand Down
8 changes: 8 additions & 0 deletions libc/config/linux/riscv/exclude.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
include(CheckSymbolExists)
check_symbol_exists(SYS_faccessat2 "sys/syscall.h" HAVE_SYS_FACCESSAT2)
if(NOT HAVE_SYS_FACCESSAT2)
message(VERBOSE "unistd.faccessat excluded from build, faccessat2 syscall is not available on the system")
list(APPEND TARGET_LLVMLIBC_REMOVED_ENTRYPOINTS
libc.src.unistd.faccessat
)
endif()
1 change: 1 addition & 0 deletions libc/config/linux/x86_64/exclude.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ endif()
include(CheckSymbolExists)
check_symbol_exists(SYS_faccessat2 "sys/syscall.h" HAVE_SYS_FACCESSAT2)
if(NOT HAVE_SYS_FACCESSAT2)
message(VERBOSE "unistd.faccessat excluded from build, faccessat2 syscall is not available on the system")
list(APPEND TARGET_LLVMLIBC_REMOVED_ENTRYPOINTS
libc.src.unistd.faccessat
)
Expand Down
Loading