Skip to content

[clang-doc] create a separate cmake file for clang-doc's lit tests #165935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2025
Merged

[clang-doc] create a separate cmake file for clang-doc's lit tests #165935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang-tools-extra/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,7 @@ add_lit_testsuite(check-clang-extra "Running clang-tools-extra/test"

add_lit_testsuites(CLANG-EXTRA ${CMAKE_CURRENT_SOURCE_DIR}
DEPENDS ${CLANG_TOOLS_TEST_DEPS}
SKIP "^clang-doc"
Copy link
Member

@petrhosek petrhosek Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something that needs to be done in this patch, but I think we should consider adding CMakeLists.txt files for all other subdirectories and then remove this target altogether.

Copy link
Member Author

@evelez7 evelez7 Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this as well. I opened #165820. I thought about closing it after merging this but I might keep it open. I don't know how tied the other projects are to that target and CMake file.

)

add_subdirectory(clang-doc)
7 changes: 7 additions & 0 deletions clang-tools-extra/test/clang-doc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Specialize the clang-doc target to avoid building other projects
add_lit_testsuite(check-clang-extra-clang-doc "Running clang-doc tests"
${CMAKE_CURRENT_BINARY_DIR}
EXCLUDE_FROM_CHECK_ALL
DEPENDS clang-doc
DEPENDS ${LLVM_UTILS_DEPS}
)