[VPlan] Support isa/dyn_cast from VPRecipeBase to VPIRMetadata (NFC). #166245

fhahn · 2025-11-03T21:59:57Z

Implement CastInfo from VPRecipeBase to VPIRMetadata to support isa/dyn_Cast. This is similar to CastInfoVPPhiAccessors, supporting dyn_cast by down-casting to the concrete recipe types inheriting from VPIRMetadata.

Can be used for more generalized VPIRMetadata printing following #165825.

Implement CastInfo from VPRecipeBase to VPIRMetadata to support isa/dyn_Cast. This is similar to CastInfoVPPhiAccessors, supporting dyn_cast by down-casting to the concrete recipe types inheriting from VPIRMetadata. Can be used for more generalized VPIRMetadata printing following llvm#165825.

llvmbot · 2025-11-03T22:00:30Z

@llvm/pr-subscribers-vectorizers

@llvm/pr-subscribers-llvm-transforms

Author: Florian Hahn (fhahn)

Changes

Implement CastInfo from VPRecipeBase to VPIRMetadata to support isa/dyn_Cast. This is similar to CastInfoVPPhiAccessors, supporting dyn_cast by down-casting to the concrete recipe types inheriting from VPIRMetadata.

Can be used for more generalized VPIRMetadata printing following #165825.

Full diff: https://github.com/llvm/llvm-project/pull/166245.diff

1 Files Affected:

(modified) llvm/lib/Transforms/Vectorize/VPlan.h (+70)

diff --git a/llvm/lib/Transforms/Vectorize/VPlan.h b/llvm/lib/Transforms/Vectorize/VPlan.h
index cfe1f1e9d7528..2c47aa3f35e02 100644
--- a/llvm/lib/Transforms/Vectorize/VPlan.h
+++ b/llvm/lib/Transforms/Vectorize/VPlan.h
@@ -3815,6 +3815,76 @@ template <>
 struct CastInfo<VPPhiAccessors, const VPRecipeBase *>
     : CastInfoVPPhiAccessors<const VPRecipeBase *> {};
 
+/// Casting from VPRecipeBase -> VPIRMetadata is supported for all recipe types
+/// implementing VPIRMetadata. Used by isa<> & co.
+template <> struct CastIsPossible<VPIRMetadata, const VPRecipeBase *> {
+  static inline bool isPossible(const VPRecipeBase *R) {
+    return isa<VPInstruction, VPWidenRecipe, VPWidenCastRecipe,
+               VPWidenIntrinsicRecipe, VPWidenCallRecipe, VPWidenSelectRecipe,
+               VPReplicateRecipe, VPInterleaveRecipe, VPInterleaveEVLRecipe,
+               VPWidenLoadRecipe, VPWidenLoadEVLRecipe, VPWidenStoreRecipe,
+               VPWidenStoreEVLRecipe>(R);
+  }
+};
+
+/// Support casting from VPRecipeBase -> VPIRMetadata, by down-casting to the
+/// recipe types implementing VPIRMetadata. Used by cast<>, dyn_cast<> & co.
+template <typename SrcTy>
+struct CastInfoVPIRMetadata : public CastIsPossible<VPIRMetadata, SrcTy> {
+
+  using Self = CastInfo<VPIRMetadata, SrcTy>;
+
+  /// doCast is used by cast<>.
+  static inline VPIRMetadata *doCast(SrcTy R) {
+    return const_cast<VPIRMetadata *>([R]() -> const VPIRMetadata * {
+      switch (R->getVPDefID()) {
+      case VPDef::VPInstructionSC:
+        return cast<VPInstruction>(R);
+      case VPDef::VPWidenSC:
+        return cast<VPWidenRecipe>(R);
+      case VPDef::VPWidenCastSC:
+        return cast<VPWidenCastRecipe>(R);
+      case VPDef::VPWidenIntrinsicSC:
+        return cast<VPWidenIntrinsicRecipe>(R);
+      case VPDef::VPWidenCallSC:
+        return cast<VPWidenCallRecipe>(R);
+      case VPDef::VPWidenSelectSC:
+        return cast<VPWidenSelectRecipe>(R);
+      case VPDef::VPReplicateSC:
+        return cast<VPReplicateRecipe>(R);
+      case VPDef::VPInterleaveSC:
+        return cast<VPInterleaveRecipe>(R);
+      case VPDef::VPInterleaveEVLSC:
+        return cast<VPInterleaveEVLRecipe>(R);
+      case VPDef::VPWidenLoadSC:
+        return cast<VPWidenLoadRecipe>(R);
+      case VPDef::VPWidenLoadEVLSC:
+        return cast<VPWidenLoadEVLRecipe>(R);
+      case VPDef::VPWidenStoreSC:
+        return cast<VPWidenStoreRecipe>(R);
+      case VPDef::VPWidenStoreEVLSC:
+        return cast<VPWidenStoreEVLRecipe>(R);
+      default:
+        llvm_unreachable("invalid recipe for VPIRMetadata cast");
+      }
+    }());
+  }
+
+  /// doCastIfPossible is used by dyn_cast<>.
+  static inline VPIRMetadata *doCastIfPossible(SrcTy f) {
+    if (!Self::isPossible(f))
+      return nullptr;
+    return doCast(f);
+  }
+};
+
+template <>
+struct CastInfo<VPIRMetadata, VPRecipeBase *>
+    : CastInfoVPIRMetadata<VPRecipeBase *> {};
+template <>
+struct CastInfo<VPIRMetadata, const VPRecipeBase *>
+    : CastInfoVPIRMetadata<const VPRecipeBase *> {};
+
 /// VPBasicBlock serves as the leaf of the Hierarchical Control-Flow Graph. It
 /// holds a sequence of zero or more VPRecipe's each representing a sequence of
 /// output IR instructions. All PHI-like recipes must come before any non-PHI recipes.

david-arm · 2025-11-04T13:32:34Z

llvm/lib/Transforms/Vectorize/VPlan.h

+struct CastInfo<VPIRMetadata, VPRecipeBase *>
+    : CastInfoVPIRMetadata<VPRecipeBase *> {};
+template <>
+struct CastInfo<VPIRMetadata, const VPRecipeBase *>


Aren't we casting from a const to a non-const pointer here - is this safe?

(somehow my response seem to got lost, but that should be taken care of now)

david-arm · 2025-11-04T13:38:43Z

llvm/lib/Transforms/Vectorize/VPlan.h

+
+  /// doCast is used by cast<>.
+  static inline VPIRMetadata *doCast(SrcTy R) {
+    return const_cast<VPIRMetadata *>([R]() -> const VPIRMetadata * {


This looks a bit odd. We potentially take a non-const SrcTy, cast it to a non-const VPInstruction, etc., then return const VPIRMetadata * from the lambda function, which then returns VPIRMetadata *. Why not just do

return cast<VPIRMetadata *> ([R]() -> VPIRMetadata * { ...

?

Yes, this was not 100% const-correct. I updated the patch to avoid this, by adding a templated castToVPIRMetadata, which can take care of both casting const * -> const *and non-const -> non-const.

Not sure if there's a nicer way to do that safely.

…adata

fhahn · 2025-11-12T21:28:28Z

ping :)

…adata

david-arm

LGTM. Seems fine to me.

ayalz

Couple of post-approval consistency nits.

ayalz · 2025-11-18T07:10:45Z

llvm/lib/Transforms/Vectorize/VPlan.h

+  using Self = CastInfo<VPIRMetadata, SrcTy>;
+  using RetTy = decltype(detail::castToVPIRMetadata(std::declval<SrcTy>()));
+
+  static inline RetTy doCast(SrcTy R) { return detail::castToVPIRMetadata(R); }


Suggested change

static inline RetTy doCast(SrcTy R) { return detail::castToVPIRMetadata(R); }

/// doCast is used by cast<>.

static inline RetTy doCast(SrcTy R) { return detail::castToVPIRMetadata(R); }

done thanks

ayalz · 2025-11-18T07:11:10Z

llvm/lib/Transforms/Vectorize/VPlan.h

+
+  static inline RetTy doCast(SrcTy R) { return detail::castToVPIRMetadata(R); }
+
+  static inline RetTy doCastIfPossible(SrcTy R) {


Suggested change

static inline RetTy doCastIfPossible(SrcTy R) {

/// doCastIfPossible is used by dyn_cast<>.

static inline RetTy doCastIfPossible(SrcTy R) {

done thanks

ayalz · 2025-11-18T07:13:33Z

llvm/lib/Transforms/Vectorize/VPlan.h

+/// Casting from VPRecipeBase -> VPIRMetadata is supported for all recipe types
+/// implementing VPIRMetadata. Used by isa<> & co.
+namespace detail {
+/// Returns const VPIRMetadata* if input is const, and VPIRMetadata* otherwise.


Independent consistency follow-up: should the above down-casting to VPPhiAccessors also support non/const-ness.

The above supports const/non-const with const_cast. I can update it to use the same approach as here, after this PR lands

ayalz · 2025-11-18T07:16:13Z

llvm/lib/Transforms/Vectorize/VPlan.h

+    return isa<VPInstruction, VPWidenRecipe, VPWidenCastRecipe,
+               VPWidenIntrinsicRecipe, VPWidenCallRecipe, VPWidenSelectRecipe,
+               VPReplicateRecipe, VPInterleaveRecipe, VPInterleaveEVLRecipe,
+               VPWidenLoadRecipe, VPWidenLoadEVLRecipe, VPWidenStoreRecipe,
+               VPWidenStoreEVLRecipe>(R);


Would be good to note at VPIRMetadata that any recipe inheriting from it should be listed here. Also for VPPhiAccessors.

added thanks

…adata

…data (NFC). (#166245) Implement CastInfo from VPRecipeBase to VPIRMetadata to support isa/dyn_Cast. This is similar to CastInfoVPPhiAccessors, supporting dyn_cast by down-casting to the concrete recipe types inheriting from VPIRMetadata. Can be used for more generalized VPIRMetadata printing following llvm/llvm-project#165825. PR: llvm/llvm-project#166245

… (#166245) Implement CastInfo from VPRecipeBase to VPIRMetadata to support isa/dyn_Cast. This is similar to CastInfoVPPhiAccessors, supporting dyn_cast by down-casting to the concrete recipe types inheriting from VPIRMetadata. Can be used for more generalized VPIRMetadata printing following llvm/llvm-project#165825. PR: llvm/llvm-project#166245 Signed-off-by: Hafidz Muzakky <[email protected]>

fhahn requested review from Mel-Chen, aniragil, ayalz and rengolin November 3, 2025 21:59

llvmbot added vectorizers llvm:transforms labels Nov 3, 2025

fhahn mentioned this pull request Nov 3, 2025

[VPlan] Implement printing VPIRMetadata. #165825

Closed

david-arm reviewed Nov 4, 2025

View reviewed changes

fhahn added 2 commits November 6, 2025 19:01

Merge remote-tracking branch 'origin/main' into vplan-dyncast-vpirmet…

ac805f4

…adata

!fixup add unit testing, avoid const_cast

723d7d0

fhahn mentioned this pull request Nov 12, 2025

[VPlan] Hoist loads with invariant addresses using noalias metadata. #166247

Merged

Merge branch 'main' into vplan-dyncast-vpirmetadata

cb3e110

Merge remote-tracking branch 'origin/main' into vplan-dyncast-vpirmet…

0c52096

…adata

fhahn mentioned this pull request Nov 17, 2025

[VPlan] Implement printing VPIRMetadata. #168385

Open

david-arm approved these changes Nov 17, 2025

View reviewed changes

ayalz reviewed Nov 18, 2025

View reviewed changes

fhahn added 2 commits November 18, 2025 10:39

Merge remote-tracking branch 'origin/main' into vplan-dyncast-vpirmet…

8f488f3

…adata

!fixup simplify a bit, add various notes/comments as suggested, thanks

effe8a4

fhahn enabled auto-merge (squash) November 18, 2025 11:02

fhahn merged commit 2432465 into llvm:main Nov 18, 2025
9 of 10 checks passed

fhahn deleted the vplan-dyncast-vpirmetadata branch November 18, 2025 16:16

	static inline RetTy doCast(SrcTy R) { return detail::castToVPIRMetadata(R); }
	/// doCast is used by cast<>.
	static inline RetTy doCast(SrcTy R) { return detail::castToVPIRMetadata(R); }


		static inline RetTy doCast(SrcTy R) { return detail::castToVPIRMetadata(R); }

		static inline RetTy doCastIfPossible(SrcTy R) {

	static inline RetTy doCastIfPossible(SrcTy R) {
	/// doCastIfPossible is used by dyn_cast<>.
	static inline RetTy doCastIfPossible(SrcTy R) {

[VPlan] Support isa/dyn_cast from VPRecipeBase to VPIRMetadata (NFC). #166245

[VPlan] Support isa/dyn_cast from VPRecipeBase to VPIRMetadata (NFC). #166245

Uh oh!

Conversation

fhahn commented Nov 3, 2025

Uh oh!

llvmbot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fhahn commented Nov 12, 2025

Uh oh!

david-arm left a comment

Choose a reason for hiding this comment

Uh oh!

ayalz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

llvmbot commented Nov 3, 2025 •

edited

Loading