Skip to content

[libc] Add printf error handling (with fixes #2) #166517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 5, 2025
Merged

[libc] Add printf error handling (with fixes #2) #166517

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7cf6075
Add printf error handling
mleleszi Nov 5, 2025
999ff25
Fix fprintf test checkinf for specific errnos
mleleszi Nov 5, 2025
4f69236
Guard errno checking fprintf tests to not run on the GPU
mleleszi Nov 5, 2025
dd0e9d2
Fix gpu guards
mleleszi Nov 5, 2025
3d048d9
Fix includes
mleleszi Nov 5, 2025
57e7e9d
Merge branch 'main' into libc-printf-error-handling-fixes
mleleszi Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libc/test/src/stdio/fprintf_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,16 @@ TEST(LlvmLibcFPrintfTest, WriteToFile) {
written =
LIBC_NAMESPACE::fprintf(file, "Writing to a read only file should fail.");
EXPECT_LT(written, 0);
#if !defined(__AMDGPU__) && !defined(__NVPTX__)
ASSERT_ERRNO_FAILURE();
#endif

ASSERT_EQ(printf_test::fclose(file), 0);
}

#if !defined(LIBC_COPT_PRINTF_NO_NULLPTR_CHECKS) && \
!defined(LIBC_COPT_PRINTF_DISABLE_WRITE_INT)
!defined(LIBC_COPT_PRINTF_DISABLE_WRITE_INT) && !defined(__AMDGPU__) && \
!defined(__NVPTX__)
TEST(LlvmLibcFPrintfTest, NullPtrCheck) {
const char *FILENAME = APPEND_LIBC_TEST("fprintf_nullptr.test");
auto FILE_PATH = libc_make_test_file_path(FILENAME);
Expand Down
2 changes: 2 additions & 0 deletions libc/test/src/stdio/vfprintf_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ TEST(LlvmLibcVFPrintfTest, WriteToFile) {

written = call_vfprintf(file, "Writing to a read only file should fail.");
EXPECT_LT(written, 0);
#if !defined(__AMDGPU__) && !defined(__NVPTX__)
ASSERT_ERRNO_FAILURE();
#endif

ASSERT_EQ(printf_test::fclose(file), 0);
}
Loading