-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[compiler-rt][sanitizers] Mark three tests as unsupported on Android #166639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler-rt][sanitizers] Mark three tests as unsupported on Android #166639
Conversation
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Aiden Grossman (boomanaiden154) ChangesThese tests were already XFailed on Android, but are unresolved when Full diff: https://github.com/llvm/llvm-project/pull/166639.diff 3 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/log-path_test.cpp b/compiler-rt/test/asan/TestCases/log-path_test.cpp
index 6875d57c43cc0..22f077fb54680 100644
--- a/compiler-rt/test/asan/TestCases/log-path_test.cpp
+++ b/compiler-rt/test/asan/TestCases/log-path_test.cpp
@@ -1,6 +1,5 @@
// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
-// XFAIL: android
-// UNSUPPORTED: ios
+// UNSUPPORTED: ios, android
//
// The for loop in the backticks below requires bash.
// REQUIRES: shell
diff --git a/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp b/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp
index 53166ccded390..f4781a7d47647 100644
--- a/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp
+++ b/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp
@@ -9,8 +9,8 @@
// RUN: FileCheck %s --check-prefix=CHECK-ERROR < %t-dir/asan.log.verbose-log-path_test-binary.*
// FIXME: only FreeBSD, NetBSD and Linux have verbose log paths now.
-// XFAIL: target={{.*windows-msvc.*}},android
-// UNSUPPORTED: ios
+// XFAIL: target={{.*windows-msvc.*}}
+// UNSUPPORTED: ios, android
#include <stdlib.h>
#include <string.h>
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cpp
index 6ba7025bf7578..68e76bb49f631 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cpp
@@ -7,7 +7,7 @@
// RUN: not %run %t %t-out && FileCheck < %t-out %s
// REQUIRES: stable-runtime
-// XFAIL: android && asan
+// UNSUPPORTED: android
#include <sanitizer/common_interface_defs.h>
#include <stdio.h>
|
Created using spr 1.3.7 [skip ci]
These tests were already XFailed on Android, but are unresolved when running under the internal shell rather than failing due to missing file paths, which is likely the same reason they are xfailed. This does make it slightly worse if someone accidentally fixes these tests for Android without realizing it, but the alternative is likely fixing the functionality/test on Android. Pull Request: llvm#166639
Created using spr 1.3.7 [skip ci]
These tests were already XFailed on Android, but are unresolved when running under the internal shell rather than failing due to missing file paths, which is likely the same reason they are xfailed. This does make it slightly worse if someone accidentally fixes these tests for Android without realizing it, but the alternative is likely fixing the functionality/test on Android. Pull Request: llvm#166639
compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cpp
Show resolved
Hide resolved
…on Android These tests were already XFailed on Android, but are unresolved when running under the internal shell rather than failing due to missing file paths, which is likely the same reason they are xfailed. This does make it slightly worse if someone accidentally fixes these tests for Android without realizing it, but the alternative is likely fixing the functionality/test on Android. Reviewers: vitalybuka, eugenis, thurstond, fmayer Reviewed By: fmayer Pull Request: llvm/llvm-project#166639
These tests were already XFailed on Android, but are unresolved when running under the internal shell rather than failing due to missing file paths, which is likely the same reason they are xfailed. This does make it slightly worse if someone accidentally fixes these tests for Android without realizing it, but the alternative is likely fixing the functionality/test on Android. Reviewers: vitalybuka, eugenis, thurstond, fmayer Reviewed By: fmayer Pull Request: llvm#166639
These tests were already XFailed on Android, but are unresolved when
running under the internal shell rather than failing due to missing file
paths, which is likely the same reason they are xfailed. This does make
it slightly worse if someone accidentally fixes these tests for Android
without realizing it, but the alternative is likely fixing the
functionality/test on Android.