Skip to content

[libc++] Guard fileno() and isatty() usage correctly. #166668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2025
Merged

[libc++] Guard fileno() and isatty() usage correctly. #166668

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1a9925
[libc++] Guard fileno() and isatty() usage correctly.
wecing Nov 5, 2025
303656b
Merge branch 'llvm:main' into main
wecing Nov 6, 2025
b6a99b1
[libcxx] special-handle Newlib in print.cpp.
wecing Nov 7, 2025
5ac5e9c
Check _POSIX_C_SOURCE instead of __POSIX_VISIBLE.
wecing Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion libcxx/src/print.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@
# include <windows.h>
#elif __has_include(<unistd.h>)
# include <unistd.h>
# if defined(_NEWLIB_VERSION)
# if defined(_POSIX_C_SOURCE) && __has_include(<stdio.h>)
# include <stdio.h>
# define HAS_FILENO_AND_ISATTY
# endif
# else
# define HAS_FILENO_AND_ISATTY
# endif
#endif

_LIBCPP_BEGIN_NAMESPACE_STD
Expand Down Expand Up @@ -56,7 +64,7 @@ __write_to_windows_console([[maybe_unused]] FILE* __stream, [[maybe_unused]] wst
}
# endif // _LIBCPP_HAS_WIDE_CHARACTERS

#elif __has_include(<unistd.h>) // !_LIBCPP_WIN32API
#elif defined(HAS_FILENO_AND_ISATTY) // !_LIBCPP_WIN32API

_LIBCPP_EXPORTED_FROM_ABI bool __is_posix_terminal(FILE* __stream) { return isatty(fileno(__stream)); }
#endif
Expand Down
Loading