Skip to content

[libc] Add localtime_r to baremetal entrypoints #166677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2025
Merged

[libc] Add localtime_r to baremetal entrypoints #166677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f9d6cd
[libc] Add localtime_r to baremetal entrypoints
Prabhuk Nov 6, 2025
5c25a96
Add localtime. Fix baremetal compilation failures.
Prabhuk Nov 6, 2025
d44eea2
Cleanup build rules.
Prabhuk Nov 6, 2025
906e12d
Add risc-v entry points.
Prabhuk Nov 6, 2025
628efcd
Add aarch64 entrypoints.
Prabhuk Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions libc/config/baremetal/aarch64/entrypoints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,8 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.time.difftime
libc.src.time.gmtime
libc.src.time.gmtime_r
# TODO: Re-enable these when tests aren't broken.
# libc.src.time.localtime
# libc.src.time.localtime_r
libc.src.time.localtime
libc.src.time.localtime_r
libc.src.time.mktime
libc.src.time.strftime
libc.src.time.strftime_l
Expand Down
2 changes: 2 additions & 0 deletions libc/config/baremetal/arm/entrypoints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,8 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.time.difftime
libc.src.time.gmtime
libc.src.time.gmtime_r
libc.src.time.localtime
libc.src.time.localtime_r
Copy link
Member

@petrhosek petrhosek Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include libc.src.time.localtime and update other baremetal/*/entrypoints.txt files?

Copy link
Contributor Author

@Prabhuk Prabhuk Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to include this for aarch64 baremetal target as well? I see @michaelrj-google removed localtime* from aarch64 in this PR after it had previously landed: #156776

Copy link
Contributor

@michaelrj-google michaelrj-google Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was just a quick fix, if the tests are passing now feel free to enable.

Copy link
Contributor Author

@Prabhuk Prabhuk Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'll merge this and keep an eye out for post submit builder emails.

libc.src.time.mktime
libc.src.time.strftime
libc.src.time.strftime_l
Expand Down
2 changes: 2 additions & 0 deletions libc/config/baremetal/riscv/entrypoints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,8 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.time.difftime
libc.src.time.gmtime
libc.src.time.gmtime_r
libc.src.time.localtime
libc.src.time.localtime_r
libc.src.time.mktime
libc.src.time.strftime
libc.src.time.strftime_l
Expand Down
8 changes: 4 additions & 4 deletions libc/src/time/baremetal/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ add_entrypoint_object(
localtime
SRCS
localtime.cpp
../time_utils.cpp
HDRS
../localtime.h
time_utils.h
../time_utils.h
DEPENDS
.time_utils
libc.hdr.types.struct_tm
libc.hdr.types.time_t
)
Expand All @@ -37,11 +37,11 @@ add_entrypoint_object(
localtime_r
SRCS
localtime_r.cpp
../time_utils.cpp
HDRS
../localtime.h
time_utils.h
../time_utils.h
DEPENDS
.time_utils
libc.hdr.types.struct_tm
libc.hdr.types.time_t
)
Loading