Skip to content

[sanitizer_common] [Darwin] Fix strncmp => internal_strncmp in NextSegmentLoad #166972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[sanitizer_common] [Darwin] Fix strncmp => internal_strncmp in NextSegmentLoad #166972

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2c8d4c
[sanitizer_common] [Darwin] Fix strncmp => internal_strncmp in NextSe…
ndrewh Nov 7, 2025
a1f3fad
absolutely BEAUTIFUL clang-format
ndrewh Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler-rt/lib/sanitizer_common/sanitizer_procmaps_mac.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@ static bool NextSegmentLoad(MemoryMappedSegment *segment,
layout_data->current_load_cmd_count--;
if (((const load_command *)lc)->cmd == kLCSegment) {
const SegmentCommand* sc = (const SegmentCommand *)lc;
if (strncmp(sc->segname, "__LINKEDIT", sizeof("__LINKEDIT")) == 0) {
if (internal_strncmp(sc->segname, "__LINKEDIT", sizeof("__LINKEDIT")) ==
0) {
// The LINKEDIT sections are for internal linker use, and may alias
// with the LINKEDIT section for other modules. (If we included them,
// our memory map would contain overlappping sections.)
Expand Down