Skip to content

[clang-tidy][NFC] Enable "HeaderFilterRegex" in clang-tidy codebase #167020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

[clang-tidy][NFC] Enable "HeaderFilterRegex" in clang-tidy codebase #167020

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6400f25
[clang-tidy][NFC] Enable HeaderFilterRegex in clang-tidy codebase
vbvictor Nov 7, 2025
2d18f67
Merge branch 'main' into acp/vbvictor/2863116137097814
vbvictor Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clang-tools-extra/clang-tidy/.clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
InheritParentConfig: true
HeaderFilterRegex: 'clang-tools-extra/clang-tidy'
ExcludeHeaderFilterRegex: 'include-cleaner|clang-query'
Copy link
Contributor Author

@vbvictor vbvictor Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to do this because I got errors from files like this:

llvm/llvm-project/clang-tools-extra/clang-tidy/misc/../../include-cleaner/include/clang-include-cleaner/Types.h:22:9

So it matched on regex clang-tools-extra/clang-tidy but actually it's header from another subproject.

If anyone have better ideas - please tell!

Copy link
Contributor

@localspook localspook Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the relevant code:

llvm-project/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

Lines 590 to 594 in 7734276

const StringRef FileName(File->getName());
LastErrorRelatesToUserCode = LastErrorRelatesToUserCode ||
Sources.isInMainFile(Location) ||
(getHeaderFilter()->match(FileName) &&
!getExcludeHeaderFilter()->match(FileName));

Maybe we should normalize FileName before matching on it? i.e.:

clang-tools-extra/clang-tidy/misc/../../include-cleaner/include/clang-include-cleaner/Types.h
->
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h

Copy link
Contributor

@localspook localspook Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, the reason we have these relative paths in the first place is because include-cleaner forces us to do this:

llvm-project/clang-tools-extra/clang-tidy/misc/CMakeLists.txt

Line 10 in 7734276

include_directories(BEFORE "${CMAKE_CURRENT_SOURCE_DIR}/../../include-cleaner/include")

...which is just really ugly. I've opened #167110 to fix it. (It happens to also fix this problem, but I think there's an underlying problem on our end too.)

Copy link
Contributor Author

@vbvictor vbvictor Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI same happens with clang-query headers that also emit relative paths

Copy link
Contributor

@localspook localspook Nov 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's right, that PR doesn't fully fix this problem then

Checks: >
bugprone-*,
-bugprone-assignment-in-if-condition,
Expand Down