Skip to content

[lld][macho] Fix segfault while processing malformed object file. #167025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 11, 2025
+267 −0
Merged

[lld][macho] Fix segfault while processing malformed object file. #167025

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1ced6f
[lld][macho] Fix segfault while processing malformed object file.
Prabhuk Nov 7, 2025
5e2c87b
Emit fatal error instead of using error llvm_unreachable.
Prabhuk Nov 10, 2025
d077666
Add regression test.
Prabhuk Nov 10, 2025
309e01c
Nit: Improve error message.
Prabhuk Nov 10, 2025
a9e1149
Test for section index larger than section size.
Prabhuk Nov 11, 2025
6ec35a9
Fix the error messages as suggested.
Prabhuk Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lld/MachO/InputFiles.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,11 @@ void ObjFile::parseSymbols(ArrayRef<typename LP::section> sectionHeaders,
continue;

if ((sym.n_type & N_TYPE) == N_SECT) {
if (sym.n_sect == 0) {
error("Section symbol " + StringRef(strtab + sym.n_strx) + " in " +
toString(this) + " has an invalid section index of 0");
llvm_unreachable("Section symbol without an associated section.");
}
Subsections &subsections = sections[sym.n_sect - 1]->subsections;
// parseSections() may have chosen not to parse this section.
if (subsections.empty())
Expand Down