-
Notifications
You must be signed in to change notification settings - Fork 15.2k
XCore: Add iprintf to RuntimeLibcalls system library #167088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arsenm
wants to merge
1
commit into
users/arsenm/runtime-libcalls/add-small-printf-emscripten
Choose a base branch
from
users/arsenm/xcore/add-iprintf-runtime-libcalls
base: users/arsenm/runtime-libcalls/add-small-printf-emscripten
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
XCore: Add iprintf to RuntimeLibcalls system library #167088
arsenm
wants to merge
1
commit into
users/arsenm/runtime-libcalls/add-small-printf-emscripten
from
users/arsenm/xcore/add-iprintf-runtime-libcalls
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2025
This was referenced Nov 8, 2025
Contributor
Author
Member
|
@llvm/pr-subscribers-llvm-selectiondag @llvm/pr-subscribers-llvm-transforms Author: Matt Arsenault (arsenm) ChangesFull diff: https://github.com/llvm/llvm-project/pull/167088.diff 2 Files Affected:
diff --git a/llvm/include/llvm/IR/RuntimeLibcalls.td b/llvm/include/llvm/IR/RuntimeLibcalls.td
index ad11216c6ee9d..acc9a1bfc0f5b 100644
--- a/llvm/include/llvm/IR/RuntimeLibcalls.td
+++ b/llvm/include/llvm/IR/RuntimeLibcalls.td
@@ -3349,6 +3349,7 @@ def XCoreSystemLibrary
(add DefaultRuntimeLibcallImpls,
exp10f, exp10, exp10l_f128,
__memcpy_4,
+ iprintf, siprintf, fiprintf,
LibcallImpls<(add LibmF128Libcalls, LibmF128FiniteLibcalls), isGNUEnvironment>
)>;
diff --git a/llvm/test/Transforms/Util/DeclareRuntimeLibcalls/xcore.ll b/llvm/test/Transforms/Util/DeclareRuntimeLibcalls/xcore.ll
new file mode 100644
index 0000000000000..c1326ac980f4b
--- /dev/null
+++ b/llvm/test/Transforms/Util/DeclareRuntimeLibcalls/xcore.ll
@@ -0,0 +1,6 @@
+; REQUIRES: webassembly-registered-target
+; RUN: opt -S -passes=declare-runtime-libcalls -mtriple=xcore < %s | FileCheck %s
+
+; CHECK: declare void @fiprintf(...)
+; CHECK: declare void @iprintf(...)
+; CHECK: declare void @siprintf(...)
|
be6441e to
b54d80c
Compare
05dacae to
41af6ea
Compare
b54d80c to
f0a641e
Compare
41af6ea to
3f205fa
Compare
RKSimon
approved these changes
Nov 11, 2025
Collaborator
RKSimon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f0a641e to
0f391f4
Compare
17a21fd to
9dc959e
Compare
0f391f4 to
2eee7b2
Compare
2eee7b2 to
a67707c
Compare
9dc959e to
c3a79e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

No description provided.