[NFC][Support] Remove unused getLongestMatch from SpecialCaseList

[vitalybuka]

This method is not used anywhere. Remove it.

[llvmbot]

@llvm/pr-subscribers-llvm-support

Author: Vitaly Buka (vitalybuka)

Changes

This method is not used anywhere. Remove it.

---

Full diff: https://github.com/llvm/llvm-project/pull/167193.diff

2 Files Affected:

• (modified) llvm/include/llvm/Support/SpecialCaseList.h (-5)
• (modified) llvm/lib/Support/SpecialCaseList.cpp (-13)

diff --git a/llvm/include/llvm/Support/SpecialCaseList.h b/llvm/include/llvm/Support/SpecialCaseList.h
index cb8e568de02e0..a10bbc61dcc3e 100644
--- a/llvm/include/llvm/Support/SpecialCaseList.h
+++ b/llvm/include/llvm/Support/SpecialCaseList.h
@@ -218,11 +218,6 @@ class SpecialCaseList {
     LLVM_ABI unsigned getLastMatch(StringRef Prefix, StringRef Query,
                                    StringRef Category) const;
 
-    // Helper method to search by Prefix, Query, and Category. Returns
-    // matching rule, or empty string if there is no match.
-    LLVM_ABI StringRef getLongestMatch(StringRef Prefix, StringRef Query,
-                                       StringRef Category) const;
-
   private:
     friend class SpecialCaseList;
     LLVM_ABI void preprocess(bool OrderBySize);
diff --git a/llvm/lib/Support/SpecialCaseList.cpp b/llvm/lib/Support/SpecialCaseList.cpp
index 246d90cce3a43..813fce35d88fe 100644
--- a/llvm/lib/Support/SpecialCaseList.cpp
+++ b/llvm/lib/Support/SpecialCaseList.cpp
@@ -380,17 +380,4 @@ unsigned SpecialCaseList::Section::getLastMatch(StringRef Prefix,
   return LastLine;
 }
 
-StringRef SpecialCaseList::Section::getLongestMatch(StringRef Prefix,
-                                                    StringRef Query,
-                                                    StringRef Category) const {
-  StringRef LongestRule;
-  if (const Matcher *M = findMatcher(Prefix, Category)) {
-    M->match(Query, [&](StringRef Rule, unsigned) {
-      if (LongestRule.size() < Rule.size())
-        LongestRule = Rule;
-    });
-  }
-  return LongestRule;
-}
-
 } // namespace llvm

[Copilot]

Pull Request Overview

This PR removes the unused getLongestMatch method from SpecialCaseList and simplifies related code by eliminating unnecessary infrastructure that supported this unused functionality.

Key changes:

• Removed getLongestMatch method and the Match type (pair of StringRef and unsigned) it relied on
• Simplified all match() methods to return unsigned directly instead of a pair
• Removed unused OrderBySize parameter from preprocess and createInternal methods

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
llvm/include/llvm/Support/SpecialCaseList.h	Removed getLongestMatch method declaration and simplified method signatures by removing unused OrderBySize parameter
llvm/lib/Support/SpecialCaseList.cpp	Removed getLongestMatch implementation, eliminated Match type and NotMatched constant, simplified all match methods to return line numbers directly, and removed unused size-based sorting logic

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.