-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[SpecialCaseList] Switch to Version 3. #167283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vitalybuka
wants to merge
4
commits into
users/vitalybuka/spr/main.specialcaselist-switch-to-version-3
Choose a base branch
from
users/vitalybuka/spr/specialcaselist-switch-to-version-3
base: users/vitalybuka/spr/main.specialcaselist-switch-to-version-3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[SpecialCaseList] Switch to Version 3. #167283
vitalybuka
wants to merge
4
commits into
users/vitalybuka/spr/main.specialcaselist-switch-to-version-3
from
users/vitalybuka/spr/specialcaselist-switch-to-version-3
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.7
Member
|
@llvm/pr-subscribers-llvm-support Author: Vitaly Buka (vitalybuka) ChangesThe difference from Version 2 is that file path will be matched Full diff: https://github.com/llvm/llvm-project/pull/167283.diff 2 Files Affected:
diff --git a/llvm/lib/Support/SpecialCaseList.cpp b/llvm/lib/Support/SpecialCaseList.cpp
index 393f0a411eb55..b7263850dbe48 100644
--- a/llvm/lib/Support/SpecialCaseList.cpp
+++ b/llvm/lib/Support/SpecialCaseList.cpp
@@ -397,7 +397,7 @@ SpecialCaseList::addSection(StringRef SectionStr, unsigned FileNo,
bool SpecialCaseList::parse(unsigned FileIdx, const MemoryBuffer *MB,
std::string &Error) {
- unsigned long long Version = 2;
+ unsigned long long Version = 3;
StringRef Header = MB->getBuffer();
if (Header.consume_front("#!special-case-list-v"))
diff --git a/llvm/unittests/Support/SpecialCaseListTest.cpp b/llvm/unittests/Support/SpecialCaseListTest.cpp
index 1e725d5c32790..674074b009f21 100644
--- a/llvm/unittests/Support/SpecialCaseListTest.cpp
+++ b/llvm/unittests/Support/SpecialCaseListTest.cpp
@@ -314,9 +314,9 @@ TEST_F(SpecialCaseListTest, DotSlash) {
"[not]\n"
"fun:foo\n"
"src:bar\n";
- std::unique_ptr<SpecialCaseList> SCL2 = makeSpecialCaseList(IgnoreList);
- std::unique_ptr<SpecialCaseList> SCL3 =
- makeSpecialCaseList(IgnoreList, /*Version=*/3);
+ std::unique_ptr<SpecialCaseList> SCL2 = makeSpecialCaseList(IgnoreList,
+ /*Version=*/2);
+ std::unique_ptr<SpecialCaseList> SCL3 = makeSpecialCaseList(IgnoreList);
std::unique_ptr<SpecialCaseList> SCL4 = makeSpecialCaseList(IgnoreList,
/*Version=*/4);
|
vitalybuka
added a commit
to vitalybuka/llvm-project
that referenced
this pull request
Nov 10, 2025
The difference from Version 2 is that file path will be matched twice: as is and after removing leading "./". Pull Request: llvm#167283
qinkunbao
approved these changes
Nov 10, 2025
vitalybuka
added a commit
to vitalybuka/llvm-project
that referenced
this pull request
Nov 12, 2025
The difference from Version 2 is that file path will be matched twice: as is and after removing leading "./". Pull Request: llvm#167283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference from Version 2 is that file path will be matched
twice: as is and after removing leading "./".