Skip to content

Conversation

@linuxlonelyeagle
Copy link
Member

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Nov 10, 2025

@llvm/pr-subscribers-mlir-presburger

@llvm/pr-subscribers-mlir

Author: lonely eagle (linuxlonelyeagle)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/167292.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Analysis/Presburger/PresburgerSpace.h (+2-2)
diff --git a/mlir/include/mlir/Analysis/Presburger/PresburgerSpace.h b/mlir/include/mlir/Analysis/Presburger/PresburgerSpace.h
index 97573b6e45301..c7808e7201470 100644
--- a/mlir/include/mlir/Analysis/Presburger/PresburgerSpace.h
+++ b/mlir/include/mlir/Analysis/Presburger/PresburgerSpace.h
@@ -128,7 +128,7 @@ class Identifier {
 /// variable and q is a local variable. Let us put the constraints:
 ///       `1 <= x <= 7, x = 2q`
 /// on this space to get the set:
-///       `(x) : (exists q : q <= x <= 7, x = 2q)`.
+///       `(x) : (exists q : 1 <= x <= 7, x = 2q)`.
 /// An assignment to symbolic and dimension variables is valid if there
 /// exists some assignment to the local variable `q` satisfying these
 /// constraints. For this example, the set is equivalent to {2, 4, 6}.
@@ -136,7 +136,7 @@ class Identifier {
 /// of projection. In this example, `q` is existentially quantified. This can be
 /// thought of as the result of projecting out `q` from the previous example,
 /// i.e. we obtained {2, 4, 6} by projecting out the second dimension from
-/// {(2, 1), (4, 2), (6, 2)}.
+/// {(2, 1), (4, 2), (6, 3)}.
 ///
 /// Dimension variables are further divided into Domain and Range variables
 /// to support building relations.

@linuxlonelyeagle linuxlonelyeagle changed the title [mlir] Fix PresburgerSpace comment. [mlir] Fix PresburgerSpace comment Nov 10, 2025
@linuxlonelyeagle linuxlonelyeagle changed the title [mlir] Fix PresburgerSpace comment [mlir][presburger]Fix PresburgerSpace comment Nov 11, 2025
@linuxlonelyeagle linuxlonelyeagle changed the title [mlir][presburger]Fix PresburgerSpace comment [mlir][presburger] Fix PresburgerSpace comment Nov 11, 2025
@Superty
Copy link
Member

Superty commented Nov 21, 2025

Thanks for the contribution!

@Superty Superty merged commit 6be7cf0 into llvm:main Nov 21, 2025
13 checks passed
aadeshps-mcw pushed a commit to aadeshps-mcw/llvm-project that referenced this pull request Nov 26, 2025
Priyanshu3820 pushed a commit to Priyanshu3820/llvm-project that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants