Skip to content

[NVVM] Make nanosleep op duration SSA value #167331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

[NVVM] Make nanosleep op duration SSA value #167331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5e9f89
[NVVM] Make nanosleep op duration SSA value
grypp Nov 10, 2025
b8556bd
Merge branch 'main' into nvvm-nanosleep-ssa
grypp Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,7 @@ def NVVM_ReduxOp :
//===----------------------------------------------------------------------===//

def NVVM_NanosleepOp : NVVM_Op<"nanosleep">,
Arguments<(ins
ConfinedAttr<I32Attr, [IntMinValue<1>, IntMaxValue<1000000>]>:$duration)>
Arguments<(ins I32:$duration)>
{
let summary = "Suspends the thread for a specified duration.";

Expand All @@ -531,8 +530,7 @@ def NVVM_NanosleepOp : NVVM_Op<"nanosleep">,

string llvmBuilder = [{
createIntrinsicCall(builder,
llvm::Intrinsic::nvvm_nanosleep,
{builder.getInt32($duration)});
llvm::Intrinsic::nvvm_nanosleep, {$duration});
}];
let assemblyFormat = "attr-dict $duration";
}
Expand Down
8 changes: 0 additions & 8 deletions mlir/test/Target/LLVMIR/nvvmir-invalid.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,14 +578,6 @@ llvm.func @ld_matrix(%arg0: !llvm.ptr<3>) {

// -----

llvm.func @nanosleep() {
// expected-error@+1 {{integer constant out of range for attribute}}
nvvm.nanosleep 100000000000000
llvm.return
}

// -----

llvm.func @clusterlaunchcontrol_query_cancel_is_canceled_invalid_return_type(%try_cancel_response: i128) {
// expected-error@+1 {{'nvvm.clusterlaunchcontrol.query.cancel' op is_canceled query type returns an i1}}
%res = nvvm.clusterlaunchcontrol.query.cancel query = is_canceled, %try_cancel_response : i32
Expand Down
6 changes: 3 additions & 3 deletions mlir/test/Target/LLVMIR/nvvmir.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,8 +970,8 @@ llvm.func @nvvm_pmevent() {
// -----

// CHECK-LABEL: @nanosleep
llvm.func @nanosleep() {
// CHECK: call void @llvm.nvvm.nanosleep(i32 4000)
nvvm.nanosleep 4000
llvm.func @nanosleep(%duration: i32) {
// CHECK: call void @llvm.nvvm.nanosleep(i32 %{{.*}})
nvvm.nanosleep %duration
llvm.return
}