[LLDB] Fix lldb failure caused by 95db31e7f6. #167423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlavaee
changed the title
Member
|
@llvm/pr-subscribers-lldb Author: Rahman Lavaee (rlavaee) ChangesFull diff: https://github.com/llvm/llvm-project/pull/167423.diff 1 Files Affected:
diff --git a/lldb/test/API/functionalities/thread/step_until/function.list b/lldb/test/API/functionalities/thread/step_until/function.list
index 5900fe8c35069..43c121eff9631 100644
--- a/lldb/test/API/functionalities/thread/step_until/function.list
+++ b/lldb/test/API/functionalities/thread/step_until/function.list
@@ -1 +1,3 @@
-!call_me
+v1
+f call_me
+c 0
|
rlavaee
changed the title
rlavaee
changed the title
DavidSpickett
added a commit
that referenced
this pull request
Nov 11, 2025
After #167359 / 95db31e. A fix was attempted in #167423 but was not quite enough. From what I could understand, in v1 format you have to specify all the basic blocks. Where before !call_me implied they were all cold (I think, very shaky understanding here). For this test we want to see blocks like call_me/foo/call_me. So adding a line for block 1 fixes the tests. It could produce more blocks at some point but I think as long as foo is within two of them, it'll be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.