Skip to content

Conversation

@makslevental
Copy link
Contributor

@makslevental makslevental commented Nov 11, 2025

Reland #166618 with MLIRFuncUtils linked in.

@llvmbot llvmbot added the mlir label Nov 11, 2025
@llvmbot
Copy link
Member

llvmbot commented Nov 11, 2025

@llvm/pr-subscribers-mlir-func
@llvm/pr-subscribers-mlir-execution-engine
@llvm/pr-subscribers-mlir-arith

@llvm/pr-subscribers-mlir

Author: Maksim Levental (makslevental)

Changes

Reland with MLIRFuncUtils linked in.


Full diff: https://github.com/llvm/llvm-project/pull/167431.diff

1 Files Affected:

  • (modified) mlir/lib/Conversion/ArithToAPFloat/CMakeLists.txt (+1)
diff --git a/mlir/lib/Conversion/ArithToAPFloat/CMakeLists.txt b/mlir/lib/Conversion/ArithToAPFloat/CMakeLists.txt
index b0d1e46b3655f..b5ec49c087163 100644
--- a/mlir/lib/Conversion/ArithToAPFloat/CMakeLists.txt
+++ b/mlir/lib/Conversion/ArithToAPFloat/CMakeLists.txt
@@ -14,4 +14,5 @@ add_mlir_conversion_library(MLIRArithToAPFloat
   MLIRArithDialect
   MLIRArithTransforms
   MLIRFuncDialect
+  MLIRFuncUtils
   )

@makslevental makslevental merged commit 0e639ae into main Nov 11, 2025
14 checks passed
@makslevental makslevental deleted the users/makslevental/reland-apfloat branch November 11, 2025 01:13
@llvm-ci
Copy link
Collaborator

llvm-ci commented Nov 11, 2025

LLVM Buildbot has detected a new failure on builder mlir-nvidia-gcc7 running on mlir-nvidia while building mlir at step 7 "test-build-check-mlir-build-only-check-mlir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/116/builds/20794

Here is the relevant piece of the build log for the reference
Step 7 (test-build-check-mlir-build-only-check-mlir) failure: test (failure)
******************** TEST 'MLIR :: Integration/Dialect/Arith/CPU/test-apfloat-emulation.mlir' FAILED ********************
Exit Code: 2

Command Output (stdout):
--
# RUN: at line 2
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/bin/mlir-opt /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/mlir/test/Integration/Dialect/Arith/CPU/test-apfloat-emulation.mlir --convert-arith-to-apfloat --convert-to-llvm |  /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/bin/mlir-runner -e entry --entry-point-result=void              --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/lib/libmlir_c_runner_utils.so | /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/bin/FileCheck /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/mlir/test/Integration/Dialect/Arith/CPU/test-apfloat-emulation.mlir
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/bin/mlir-opt /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/mlir/test/Integration/Dialect/Arith/CPU/test-apfloat-emulation.mlir --convert-arith-to-apfloat --convert-to-llvm
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/bin/mlir-runner -e entry --entry-point-result=void --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/lib/libmlir_c_runner_utils.so
# .---command stderr------------
# | JIT session error: Symbols not found: [ __mlir_apfloat_add, printApFloat ]
# | Error: Failed to materialize symbols: { (main, { _mlir_foo, foo, _mlir_entry, entry }) }
# `-----------------------------
# error: command failed with exit status: 1
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/bin/FileCheck /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/mlir/test/Integration/Dialect/Arith/CPU/test-apfloat-emulation.mlir
# .---command stderr------------
# | FileCheck error: '<stdin>' is empty.
# | FileCheck command line:  /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/bin/FileCheck /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/mlir/test/Integration/Dialect/Arith/CPU/test-apfloat-emulation.mlir
# `-----------------------------
# error: command failed with exit status: 2

--

********************


makslevental added a commit that referenced this pull request Nov 11, 2025
makslevental added a commit that referenced this pull request Nov 11, 2025
makslevental added a commit that referenced this pull request Nov 11, 2025
makslevental added a commit that referenced this pull request Nov 11, 2025
makslevental added a commit that referenced this pull request Nov 11, 2025
…: `arith-to-apfloat` (#166618)" (#167431)" (#167436)

Reland #166618 by fixing
missing symbol issues by explicitly loading
`--shared-libs=%mlir_apfloat_wrappers` as well as
`--shared-libs=%mlir_c_runner_utils`.
makslevental added a commit that referenced this pull request Nov 11, 2025
…ing pass: `arith-to-apfloat` (#166618)" (#167431)"" (#167549)

Reverts #167436 to fix sanitizers
makslevental added a commit that referenced this pull request Nov 12, 2025
…ring pass: `arith-to-apfloat` (#166618)" (#167431)"" (#167549)

This reverts commit e67ac07.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants