Skip to content

Clang: Remove -Wperf-constraint-implies-noexcept from -Wall. #167540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2025
Merged

Clang: Remove -Wperf-constraint-implies-noexcept from -Wall. #167540

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12dc263
Clang: Remove `-Wperf-constraint-implies-noexcept` from `-Wall`.
Nov 11, 2025
0212ff5
Revert formatting change and release note move. Fix test broken by th…
Nov 11, 2025
9190685
pedantic -> nit-picky
Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clang/docs/ReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,8 @@ Improvements to Clang's diagnostics
Moved the warning for a missing (though implied) attribute on a redeclaration into this group.
Added a new warning in this group for the case where the attribute is missing/implicit on
an override of a virtual method.
- Remove ``-Wperf-constraint-implies-noexcept`` from ``-Wall``. This warning is somewhat pedantic and
Copy link
Collaborator

@AaronBallman AaronBallman Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh use of "pedantic" here may cause folks to think -pedantic is where it should live. Maybe "nit-picky"?

attempts to resolve it, by adding ``noexcept``, can create new ways for programs to crash. (#GH167540)
- Implemented diagnostics when retrieving the tuple size for types where its specialization of `std::tuple_size`
produces an invalid size (either negative or greater than the implementation limit). (#GH159563)
- Fixed fix-it hint for fold expressions. Clang now correctly places the suggested right
Expand Down
2 changes: 1 addition & 1 deletion clang/include/clang/Basic/DiagnosticGroups.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1314,7 +1314,7 @@ def Consumed : DiagGroup<"consumed">;
// DefaultIgnore in addition to putting it here.
def All : DiagGroup<"all", [Most, Parentheses, Switch, SwitchBool,
MisleadingIndentation, PackedNonPod,
VLACxxExtension, PerfConstraintImpliesNoexcept]>;
VLACxxExtension]>;

// Warnings that should be in clang-cl /w4.
def : DiagGroup<"CL4", [All, Extra]>;
Expand Down
1 change: 0 additions & 1 deletion clang/test/Misc/warning-wall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,5 @@ CHECK-NEXT: -Wmisleading-indentation
CHECK-NEXT: -Wpacked-non-pod
CHECK-NEXT: -Wvla-cxx-extension
CHECK-NEXT: -Wvla-extension-static-assert
CHECK-NEXT: -Wperf-constraint-implies-noexcept

CHECK-NOT:-W
Loading