Skip to content

Conversation

@chinmaydd
Copy link
Contributor

This seems to be the only instance of using "Local Data Share" over "Local Data Store"

@chinmaydd chinmaydd requested review from arsenm and shiltian November 11, 2025 21:25
@chinmaydd chinmaydd changed the title [AMDGPU[Doc] Update usage of Local Data "Share" to "Store" [AMDGPU][Doc] Update usage of Local Data "Share" to "Store" Nov 11, 2025
@llvmbot
Copy link
Member

llvmbot commented Nov 11, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Chinmay Deshpande (chinmaydd)

Changes

This seems to be the only instance of using "Local Data Share" over "Local Data Store"


Full diff: https://github.com/llvm/llvm-project/pull/167581.diff

1 Files Affected:

  • (modified) llvm/docs/AMDGPUUsage.rst (+1-1)
diff --git a/llvm/docs/AMDGPUUsage.rst b/llvm/docs/AMDGPUUsage.rst
index ba0e53bceade8..7f29361272c36 100644
--- a/llvm/docs/AMDGPUUsage.rst
+++ b/llvm/docs/AMDGPUUsage.rst
@@ -19449,7 +19449,7 @@ within a map that has been added by the same *vendor-name*.
      =========================== ============== ========= ===============================================================
      ".entry_point"              string                   The ELF symbol pointing to this pipeline's stage entry point.
      ".scratch_memory_size"      integer                  Scratch memory size in bytes.
-     ".lds_size"                 integer                  Local Data Share size in bytes.
+     ".lds_size"                 integer                  Local Data Store size in bytes.
      ".perf_data_buffer_size"    integer                  Performance data buffer size in bytes.
      ".vgpr_count"               integer                  Number of VGPRs used.
      ".agpr_count"               integer                  Number of AGPRs used.

@arsenm
Copy link
Contributor

arsenm commented Nov 11, 2025

local data share is used in the isa manuals

@chinmaydd
Copy link
Contributor Author

I dont like the inconsistency, but I do see the mixed usage.

@chinmaydd chinmaydd closed this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants