[AMDGPU] Adding instruction specific features #167809
+356
−171
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -166,6 +166,13 @@ class GCNSubtarget final : public AMDGPUGenSubtargetInfo, | |
| bool HasMAIInsts = false; | ||
| bool HasFP8Insts = false; | ||
| bool HasFP8ConversionInsts = false; | ||
| bool HasCubeInsts = false; | ||
| bool HasLerpInst = false; | ||
| bool HasSadInsts = false; | ||
| bool HasQsadInsts = false; | ||
| bool HasCvtNormInsts = false; | ||
| bool HasCvtPkNormVOP2Insts = false; | ||
| bool HasCvtPkNormVOP3Insts = false; | ||
| bool HasFP8E5M3Insts = false; | ||
| bool HasCvtFP8Vop1Bug = false; | ||
| bool HasPkFmacF16Inst = false; | ||
|
|
@@ -892,6 +899,20 @@ class GCNSubtarget final : public AMDGPUGenSubtargetInfo, | |
|
|
||
| bool hasFP8ConversionInsts() const { return HasFP8ConversionInsts; } | ||
|
|
||
| bool hasCubeInsts() const { return HasCubeInsts; } | ||
|
|
||
| bool hasLerpInst() const { return HasLerpInst; } | ||
|
|
||
| bool hasSadInsts() const { return HasSadInsts; } | ||
|
|
||
| bool hasQsadInsts() const { return HasQsadInsts; } | ||
|
|
||
| bool hasCvtNormInsts() const { return HasCvtNormInsts; } | ||
|
|
||
| bool hasCvtPkNormVOP2Insts() const { return HasCvtPkNormVOP2Insts; } | ||
|
|
||
| bool hasCvtPkNormVOP3Insts() const { return HasCvtPkNormVOP3Insts; } | ||
|
|
||
| bool hasFP8E5M3Insts() const { return HasFP8E5M3Insts; } | ||
|
|
||
| bool hasPkFmacF16Inst() const { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -616,15 +616,15 @@ let SubtargetPredicate = isGFX9Plus in { | |
|
|
||
| let isReMaterializable = 1 in | ||
| defm V_SAT_PK_U8_I16 : VOP1Inst_t16<"v_sat_pk_u8_i16", VOP_I16_I32>; | ||
| } // End SubtargetPredicate = isGFX9Plus | ||
|
|
||
| let mayRaiseFPException = 0, SubtargetPredicate = HasCvtNormInsts in { | ||
| defm V_CVT_NORM_I16_F16 : VOP1Inst_t16_with_profiles <"v_cvt_norm_i16_f16", | ||
| VOP_I16_F16_SPECIAL_OMOD, VOP_I16_F16_SPECIAL_OMOD_t16, VOP_I16_F16_SPECIAL_OMOD_fake16>; | ||
| defm V_CVT_NORM_U16_F16 : VOP1Inst_t16_with_profiles <"v_cvt_norm_u16_f16", | ||
| VOP_I16_F16_SPECIAL_OMOD, VOP_I16_F16_SPECIAL_OMOD_t16, VOP_I16_F16_SPECIAL_OMOD_fake16>; | ||
| } // End mayRaiseFPException = 0, SubtargetPredicate = HasCvtNormInsts | ||
|
|
||
| let SubtargetPredicate = isGFX9Only in { | ||
| defm V_SCREEN_PARTITION_4SE_B32 : VOP1Inst <"v_screen_partition_4se_b32", VOP_I32_I32>; | ||
| } // End SubtargetPredicate = isGFX9Only | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -971,7 +971,7 @@ defm V_MBCNT_HI_U32_B32 : VOP2Inst <"v_mbcnt_hi_u32_b32", VOP_I32_I32_I32, int_a | |
| } // End IsNeverUniform = 1 | ||
| defm V_LDEXP_F32 : VOP2Inst <"v_ldexp_f32", VOP_F32_F32_I32, any_fldexp>; | ||
|
|
||
| let ReadsModeReg = 0, mayRaiseFPException = 0, SubtargetPredicate = HasCvtPkNormVOP2Insts in { | ||
| defm V_CVT_PKNORM_I16_F32 : VOP2Inst <"v_cvt_pknorm_i16_f32", VOP_V2I16_F32_F32, AMDGPUpknorm_i16_f32>; | ||
| defm V_CVT_PKNORM_U16_F32 : VOP2Inst <"v_cvt_pknorm_u16_f32", VOP_V2I16_F32_F32, AMDGPUpknorm_u16_f32>; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -185,7 +185,8 @@ defm V_FMA_LEGACY_F32 : VOP3Inst <"v_fma_legacy_f32", | |
| defm V_MAD_I32_I24 : VOP3Inst <"v_mad_i32_i24", VOP3_Profile<VOP_I32_I32_I32_I32, VOP3_CLAMP>>; | ||
| defm V_MAD_U32_U24 : VOP3Inst <"v_mad_u32_u24", VOP3_Profile<VOP_I32_I32_I32_I32, VOP3_CLAMP>>; | ||
| defm V_FMA_F32 : VOP3Inst <"v_fma_f32", VOP3_Profile<VOP_F32_F32_F32_F32>, any_fma>, VOPD_Component<0x13, "v_fma_f32">; | ||
| let SubtargetPredicate = HasLerpInst in | ||
| defm V_LERP_U8 : VOP3Inst <"v_lerp_u8", VOP3_Profile<VOP_I32_I32_I32_I32>, int_amdgcn_lerp>; | ||
|
|
||
| let SchedRW = [WriteIntMul] in { | ||
| let SubtargetPredicate = HasMadU32Inst in | ||
|
|
@@ -258,12 +259,12 @@ defm V_DIV_FMAS_F64 : VOP3Inst <"v_div_fmas_f64", VOP_F64_F64_F64_F64_VCC>; | |
| } // End isCommutable = 1 | ||
|
|
||
| let isReMaterializable = 1 in { | ||
| let mayRaiseFPException = 0, SubtargetPredicate = HasCubeInsts in { | ||
| defm V_CUBEID_F32 : VOP3Inst <"v_cubeid_f32", VOP3_Profile<VOP_F32_F32_F32_F32>, int_amdgcn_cubeid>; | ||
| defm V_CUBESC_F32 : VOP3Inst <"v_cubesc_f32", VOP3_Profile<VOP_F32_F32_F32_F32>, int_amdgcn_cubesc>; | ||
| defm V_CUBETC_F32 : VOP3Inst <"v_cubetc_f32", VOP3_Profile<VOP_F32_F32_F32_F32>, int_amdgcn_cubetc>; | ||
| defm V_CUBEMA_F32 : VOP3Inst <"v_cubema_f32", VOP3_Profile<VOP_F32_F32_F32_F32>, int_amdgcn_cubema>; | ||
| } // mayRaiseFPException = 0, SubtargetPredicate = HasCubeInsts | ||
|
|
||
| defm V_BFE_U32 : VOP3Inst <"v_bfe_u32", VOP3_Profile<VOP_I32_I32_I32_I32>, AMDGPUbfe_u32>; | ||
| defm V_BFE_I32 : VOP3Inst <"v_bfe_i32", VOP3_Profile<VOP_I32_I32_I32_I32>, AMDGPUbfe_i32>; | ||
|
|
@@ -306,12 +307,12 @@ let SubtargetPredicate = HasMinimum3Maximum3F32, ReadsModeReg = 0 in { | |
| defm V_MAXIMUM3_F32 : VOP3Inst <"v_maximum3_f32", VOP3_Profile<VOP_F32_F32_F32_F32>, AMDGPUfmaximum3>; | ||
| } // End SubtargetPredicate = isGFX12Plus, ReadsModeReg = 0 | ||
|
|
||
| let isCommutable = 1, SubtargetPredicate = HasSadInsts in { | ||
| defm V_SAD_U8 : VOP3Inst <"v_sad_u8", VOP3_Profile<VOP_I32_I32_I32_I32, VOP3_CLAMP>>; | ||
| defm V_SAD_HI_U8 : VOP3Inst <"v_sad_hi_u8", VOP3_Profile<VOP_I32_I32_I32_I32, VOP3_CLAMP>>; | ||
| defm V_SAD_U16 : VOP3Inst <"v_sad_u16", VOP3_Profile<VOP_I32_I32_I32_I32, VOP3_CLAMP>>; | ||
| defm V_SAD_U32 : VOP3Inst <"v_sad_u32", VOP3_Profile<VOP_I32_I32_I32_I32, VOP3_CLAMP>>; | ||
| } // End isCommutable = 1, SubtargetPredicate = HasSadInsts | ||
| defm V_CVT_PK_U8_F32 : VOP3Inst<"v_cvt_pk_u8_f32", VOP3_Profile<VOP_I32_F32_I32_I32>, int_amdgcn_cvt_pk_u8_f32>; | ||
|
|
||
| defm V_DIV_FIXUP_F32 : VOP3Inst <"v_div_fixup_f32", DIV_FIXUP_F32_PROF, AMDGPUdiv_fixup>; | ||
|
|
@@ -424,7 +425,8 @@ def VOPProfileMQSAD : VOP3_Profile<VOP_V4I32_I64_I32_V4I32, VOP3_CLAMP> { | |
|
|
||
| let SubtargetPredicate = isGFX7Plus in { | ||
| let Constraints = "@earlyclobber $vdst", SchedRW = [WriteQuarterRate32] in { | ||
| let SubtargetPredicate = HasQsadInsts in | ||
| defm V_QSAD_PK_U16_U8 : VOP3Inst <"v_qsad_pk_u16_u8", VOP3_Profile<VOP_I64_I64_I32_I64, VOP3_CLAMP>>; | ||
| defm V_MQSAD_U32_U8 : VOP3Inst <"v_mqsad_u32_u8", VOPProfileMQSAD>; | ||
| } // End Constraints = "@earlyclobber $vdst", SchedRW = [WriteQuarterRate32] | ||
| } // End SubtargetPredicate = isGFX7Plus | ||
|
|
@@ -789,9 +791,6 @@ let isCommutable = 1 in { | |
| defm V_MAD_I32_I16 : VOP3Inst_t16 <"v_mad_i32_i16", VOP_I32_I16_I16_I32>; | ||
| } // End isCommutable = 1 | ||
|
|
||
| defm V_PACK_B32_F16 : VOP3Inst_t16 <"v_pack_b32_f16", VOP_B32_F16_F16>; | ||
|
|
||
| let isReMaterializable = 1 in { | ||
|
|
@@ -996,6 +995,11 @@ def : GCNPat<(DivergentBinFrag<or> (or_oneuse i64:$src0, i64:$src1), i64:$src2), | |
|
|
||
| } // End SubtargetPredicate = isGFX9Plus | ||
|
|
||
| let SubtargetPredicate = HasCvtPkNormVOP3Insts in { | ||
| defm V_CVT_PKNORM_I16_F16 : VOP3Inst_t16 <"v_cvt_pknorm_i16_f16", VOP_B32_F16_F16>; | ||
| defm V_CVT_PKNORM_U16_F16 : VOP3Inst_t16 <"v_cvt_pknorm_u16_f16", VOP_B32_F16_F16>; | ||
| } // end SubtargetPredicate = HasCvtPkNormVOP3Insts | ||
|
|
||
| // FIXME: Probably should hardcode clamp bit in pseudo and avoid this. | ||
| class OpSelBinOpClampPat<SDPatternOperator node, | ||
| Instruction inst> : GCNPat< | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| ; RUN: llc -mtriple=amdgcn -mcpu=fiji < %s | FileCheck -check-prefix=GCN %s | ||
|
|
||
| declare i32 @llvm.amdgcn.lerp(i32, i32, i32) #0 | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature string doesn't follow those existing names. For example, this can just be
cube-insts,lerp-insts, etc.