-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[Compiler-rt] Implement AEABI Unaligned Read/Write Helpers in compiler-rt #167913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
ce6febc
4a69df0
a3ce141
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| //===-- aeabi_uread4.c - ARM EABI Helper — Unaligned 4-Byte Memory Read --===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===-----------------------------------------------------------------------------===// | ||
|
|
||
| typedef struct { | ||
| char v[4]; | ||
| } v4; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically, to avoid breaking TBAA rules, this needs to be |
||
|
|
||
| int __aeabi_uread4(void *p) { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was going to say that surely the read functions should take a |
||
| union { | ||
| v4 v; | ||
| int u; | ||
| } u; | ||
|
|
||
| u.v = *(v4 *)p; | ||
| return u.u; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| //===-- aeabi_uread8.c - ARM EABI Helper — Unaligned 8-Byte Memory Read --===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===-----------------------------------------------------------------------------===// | ||
|
|
||
| typedef struct { | ||
| char v[8]; | ||
| } v8; | ||
|
|
||
| long long __aeabi_uread8(void *p) { | ||
| union { | ||
| v8 v; | ||
| long long u; | ||
| } u; | ||
|
|
||
| u.v = *(v8 *)p; | ||
| return u.u; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| //===-- aeabi_uread8.c - ARM EABI Helper — Unaligned 4-Byte Memory Write --===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===-----------------------------------------------------------------------------===// | ||
|
|
||
| typedef struct { | ||
| char v[4]; | ||
| } v4; | ||
|
|
||
| int __aeabi_uwrite4(int val, void *p) { | ||
| union { | ||
| v4 v; | ||
| int u; | ||
| } u; | ||
|
|
||
| u.u = val; | ||
| *(v4 *)p = u.v; | ||
|
|
||
| return val; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| //===-- aeabi_uread8.c - ARM EABI Helper — Unaligned 8-Byte Memory Write --===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===-----------------------------------------------------------------------------===// | ||
|
|
||
| typedef struct { | ||
| char v[8]; | ||
| } v8; | ||
|
|
||
| long long __aeabi_uwrite8(long long val, void *p) { | ||
| union { | ||
| v8 v; | ||
| long long u; | ||
| } u; | ||
|
|
||
| u.u = val; | ||
| *(v8 *)p = u.v; | ||
|
|
||
| return val; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| // REQUIRES: arm-target-arch || armv6m-target-arch | ||
| // RUN: %clang_builtins %s %librt -o %t && %run %t | ||
|
|
||
| #include <stdint.h> | ||
| #include <stdio.h> | ||
| #include <string.h> | ||
|
|
||
| extern int __aeabi_uread4(void *); | ||
| extern int __aeabi_uwrite4(int, void *); | ||
| extern long long __aeabi_uread8(void *); | ||
| extern long long __aeabi_uwrite8(long long, void *); | ||
|
|
||
| #define lenof(x) (sizeof((x)) / sizeof(*(x))) | ||
|
||
|
|
||
| int test_unaligned(void) { | ||
| long long target8; | ||
| int target4; | ||
| const char source[] = "abcdefghijklmno"; | ||
| static char dest1[lenof(source)], dest2[lenof(source)]; | ||
|
||
| int i, j; | ||
|
|
||
| for (i = 0; i < 7; i++) { | ||
| memcpy(&target8, source + i, 8); | ||
| if (__aeabi_uread8(source + i) != target8) { | ||
| printf("error in __aeabi_uread8 => output = %llx, expected %llx\n", | ||
| __aeabi_uread8(source + i), target8); | ||
| return 1; | ||
| } | ||
|
|
||
| memcpy(dest1, source, lenof(source)); | ||
| memcpy(dest2, source, lenof(source)); | ||
| target8 = 0x4142434445464748ULL; | ||
| if (__aeabi_uwrite8(target8, dest1 + i) != target8) { | ||
| printf("error in __aeabi_uwrite8 => output = %llx, expected %llx\n", | ||
| __aeabi_uwrite8(target8, dest1 + i), target8); | ||
| return 1; | ||
| } | ||
| memcpy(dest2 + i, &target8, 8); | ||
| if (memcmp(dest1, dest2, lenof(source)) != 0) { | ||
| int pos = -1; | ||
| printf("error in __aeabi_uwrite8: memcmp failed: buffers differ!\n"); | ||
| for (int j = 0; j < 8; ++j) { | ||
| if (dest1[j] != dest2[j]) { | ||
| pos = j; | ||
| break; | ||
| } | ||
| } | ||
| printf("error: 8-byte write mismatch at offset %d\n", pos); | ||
| return 1; | ||
| } | ||
|
|
||
| memcpy(&target4, source + i, 4); | ||
| if (__aeabi_uread4(source + i) != target4) { | ||
| printf("error in __aeabi_uread4 => output = %x, expected %x\n", | ||
| __aeabi_uread4(source + i), target4); | ||
| return 1; | ||
| } | ||
|
|
||
| memcpy(dest1, source, lenof(source)); | ||
| memcpy(dest2, source, lenof(source)); | ||
| target4 = 0x414243444; | ||
| if (__aeabi_uwrite4(target4, dest1 + i) != target4) { | ||
| printf("error in __aeabi_uwrite4 => output = %x, expected %x\n", | ||
| __aeabi_uwrite4(target4, dest1 + i), target4); | ||
| return 1; | ||
| } | ||
| memcpy(dest2 + i, &target4, 4); | ||
| if (memcmp(dest1, dest2, lenof(source)) != 0) { | ||
| int pos = -1; | ||
| printf("error in __aeabi_uwrite4: memcmp failed: buffers differ!\n"); | ||
| for (int j = 0; j < 4; ++j) { | ||
| if (dest1[j] != dest2[j]) { | ||
| pos = j; | ||
| break; | ||
| } | ||
| } | ||
| printf("error: 4-byte write mismatch at offset %d\n", pos); | ||
| return 1; | ||
| } | ||
| } | ||
| return 0; | ||
| } | ||
|
|
||
| int main() { | ||
| if (test_unaligned()) | ||
| return 1; | ||
| return 0; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a good idea to link to the document defining these functions.
https://github.com/ARM-software/abi-aa/blob/main/rtabi32/rtabi32.rst#unaligned-memory-access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done