[X86][GlobalISel] Added support for FNEG #167919
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -126,6 +126,13 @@ X86LegalizerInfo::X86LegalizerInfo(const X86Subtarget &STI, | |
| G_FSINCOS, G_FCEIL, G_FFLOOR}) | ||
| .libcall(); | ||
|
|
||
| getActionDefinitionsBuilder(G_FNEG) | ||
| .legalFor(UseX87 && !HasSSE1, {s32}) | ||
| .legalFor(UseX87 && !HasSSE2, {s64}) | ||
| .legalFor(UseX87, {s80}) | ||
| .customFor(UseX87 && !Is64Bit, {s32}) | ||
| .lowerFor({s32, s64}); | ||
|
|
||
| getActionDefinitionsBuilder(G_FSQRT) | ||
| .legalFor(HasSSE1 || UseX87, {s32}) | ||
| .legalFor(HasSSE2 || UseX87, {s64}) | ||
|
|
@@ -993,6 +1000,22 @@ bool X86LegalizerInfo::legalizeSETROUNDING(MachineInstr &MI, | |
| return true; | ||
| } | ||
|
|
||
| bool X86LegalizerInfo::legalizeFNEG(MachineInstr &MI, MachineRegisterInfo &MRI, | ||
| LegalizerHelper &Helper) const { | ||
| bool UseX87 = !Subtarget.useSoftFloat() && Subtarget.hasX87(); | ||
| bool Is64Bit = Subtarget.is64Bit(); | ||
| if (UseX87 && !Is64Bit && MI.getMF()->getFunction().getReturnType()->isFloatTy()) { | ||
| auto DstReg = MI.getOperand(0).getReg(); | ||
| auto SrcReg = MI.getOperand(1).getReg(); | ||
| auto ExtReg = MRI.createVirtualRegister(&X86::RFP80RegClass); | ||
|
||
| Helper.MIRBuilder.buildFPExt(ExtReg, SrcReg); | ||
| Helper.MIRBuilder.buildCopy(DstReg, ExtReg); | ||
|
||
| MI.eraseFromParent(); | ||
| return true; | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| bool X86LegalizerInfo::legalizeIntrinsic(LegalizerHelper &Helper, | ||
| MachineInstr &MI) const { | ||
| return true; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 6 | ||
| # RUN: llc -mtriple=i686-linux-gnu -run-pass=regbankselect,instruction-select %s -o - | FileCheck %s --check-prefixes GISEL-I686 | ||
|
|
||
| --- | ||
| name: fneg_f64 | ||
| alignment: 16 | ||
| legalized: true | ||
| fixedStack: | ||
| - { id: 0, type: default, offset: 0, size: 8, alignment: 16, stack-id: default, | ||
| isImmutable: true, isAliased: false, callee-saved-register: '', callee-saved-restored: true, | ||
| debug-info-variable: '', debug-info-expression: '', debug-info-location: '' } | ||
| body: | | ||
| bb.1: | ||
| ; GISEL-I686-LABEL: name: fneg_f64 | ||
| ; GISEL-I686: [[DEF:%[0-9]+]]:rfp64 = IMPLICIT_DEF | ||
| ; GISEL-I686-NEXT: [[CHS_Fp64_:%[0-9]+]]:rfp64 = CHS_Fp64 [[DEF]], implicit-def dead $fpsw | ||
| ; GISEL-I686-NEXT: $fp0 = COPY [[CHS_Fp64_]] | ||
| ; GISEL-I686-NEXT: RET 0, implicit $fp0 | ||
| %1:_(p0) = G_FRAME_INDEX %fixed-stack.0 | ||
| %0:_(s64) = IMPLICIT_DEF | ||
| %2:_(s64) = G_FNEG %0 | ||
| $fp0 = COPY %2(s64) | ||
| RET 0, implicit $fp0 | ||
| ... | ||
| --- | ||
| name: fneg_f32 | ||
| alignment: 16 | ||
| legalized: true | ||
| fixedStack: | ||
| - { id: 0, type: default, offset: 0, size: 4, alignment: 16, stack-id: default, | ||
| isImmutable: true, isAliased: false, callee-saved-register: '', callee-saved-restored: true, | ||
| debug-info-variable: '', debug-info-expression: '', debug-info-location: '' } | ||
| body: | | ||
| bb.1: | ||
| ; GISEL-I686-LABEL: name: fneg_f32 | ||
| ; GISEL-I686: [[LD_Fp32m:%[0-9]+]]:rfp32 = nofpexcept LD_Fp32m %fixed-stack.0, 1, $noreg, 0, $noreg, implicit-def dead $fpsw, implicit $fpcw :: (invariant load (s32) from %fixed-stack.0, align 16) | ||
| ; GISEL-I686-NEXT: [[CHS_Fp32_:%[0-9]+]]:rfp32 = CHS_Fp32 [[LD_Fp32m]], implicit-def dead $fpsw | ||
| ; GISEL-I686-NEXT: $fp0 = COPY [[CHS_Fp32_]] | ||
| ; GISEL-I686-NEXT: RET 0, implicit $fp0 | ||
| %1:_(p0) = G_FRAME_INDEX %fixed-stack.0 | ||
| %0:_(s32) = G_LOAD %1(p0) :: (invariant load (s32) from %fixed-stack.0, align 16) | ||
| %2:_(s32) = G_FNEG %0 | ||
| $fp0 = COPY %2(s32) | ||
| RET 0, implicit $fp0 | ||
| ... | ||
| --- | ||
| name: fneg_f64_mem | ||
| alignment: 16 | ||
| legalized: true | ||
| fixedStack: | ||
| - { id: 0, type: default, offset: 4, size: 4, alignment: 4, stack-id: default, | ||
| isImmutable: true, isAliased: false, callee-saved-register: '', callee-saved-restored: true, | ||
| debug-info-variable: '', debug-info-expression: '', debug-info-location: '' } | ||
| - { id: 1, type: default, offset: 0, size: 4, alignment: 16, stack-id: default, | ||
| isImmutable: true, isAliased: false, callee-saved-register: '', callee-saved-restored: true, | ||
| debug-info-variable: '', debug-info-expression: '', debug-info-location: '' } | ||
| body: | | ||
| bb.1: | ||
| ; GISEL-I686-LABEL: name: fneg_f64_mem | ||
| ; GISEL-I686: [[DEF:%[0-9]+]]:rfp64 = IMPLICIT_DEF | ||
| ; GISEL-I686-NEXT: [[CHS_Fp64_:%[0-9]+]]:rfp64 = CHS_Fp64 [[DEF]], implicit-def dead $fpsw | ||
| ; GISEL-I686-NEXT: $fp0 = COPY [[CHS_Fp64_]] | ||
| ; GISEL-I686-NEXT: RET 0, implicit $fp0 | ||
| %1:_(p0) = G_FRAME_INDEX %fixed-stack.1 | ||
| %0:_(s64) = IMPLICIT_DEF | ||
| %2:_(s64) = G_FNEG %0 | ||
| $fp0 = COPY %2(s64) | ||
| RET 0, implicit $fp0 | ||
| ... | ||
| --- | ||
| name: fneg_f32_mem | ||
| alignment: 16 | ||
| legalized: true | ||
| fixedStack: | ||
| - { id: 0, type: default, offset: 4, size: 4, alignment: 4, stack-id: default, | ||
| isImmutable: true, isAliased: false, callee-saved-register: '', callee-saved-restored: true, | ||
| debug-info-variable: '', debug-info-expression: '', debug-info-location: '' } | ||
| - { id: 1, type: default, offset: 0, size: 4, alignment: 16, stack-id: default, | ||
| isImmutable: true, isAliased: false, callee-saved-register: '', callee-saved-restored: true, | ||
| debug-info-variable: '', debug-info-expression: '', debug-info-location: '' } | ||
| body: | | ||
| bb.1: | ||
| ; GISEL-I686-LABEL: name: fneg_f32_mem | ||
| ; GISEL-I686: [[LD_Fp32m:%[0-9]+]]:rfp32 = nofpexcept LD_Fp32m %fixed-stack.1, 1, $noreg, 0, $noreg, implicit-def dead $fpsw, implicit $fpcw :: (invariant load (p0) from %fixed-stack.1) | ||
| ; GISEL-I686-NEXT: [[CHS_Fp32_:%[0-9]+]]:rfp32 = CHS_Fp32 [[LD_Fp32m]], implicit-def dead $fpsw | ||
| ; GISEL-I686-NEXT: $fp0 = COPY [[CHS_Fp32_]] | ||
| ; GISEL-I686-NEXT: RET 0, implicit $fp0 | ||
| %2:_(p0) = G_FRAME_INDEX %fixed-stack.1 | ||
| %0:_(p0) = G_LOAD %2(p0) :: (invariant load (p0) from %fixed-stack.1, align 16) | ||
| %3:_(p0) = G_FRAME_INDEX %fixed-stack.0 | ||
| %1:_(s32) = G_LOAD %3(p0) :: (invariant load (p0) from %fixed-stack.0) | ||
| %4:_(s32) = G_FNEG %1 | ||
| $fp0 = COPY %4(s32) | ||
| RET 0, implicit $fp0 | ||
| ... | ||
| --- | ||
| name: test_fp80 | ||
| alignment: 16 | ||
| legalized: true | ||
| fixedStack: | ||
| - { id: 0, type: default, offset: 0, size: 10, alignment: 16, stack-id: default, | ||
| isImmutable: true, isAliased: false, callee-saved-register: '', callee-saved-restored: true, | ||
| debug-info-variable: '', debug-info-expression: '', debug-info-location: '' } | ||
| body: | | ||
| bb.1: | ||
| ; GISEL-I686-LABEL: name: test_fp80 | ||
| ; GISEL-I686: [[LD_Fp80m:%[0-9]+]]:rfp80 = nofpexcept LD_Fp80m %fixed-stack.0, 1, $noreg, 0, $noreg, implicit-def dead $fpsw, implicit $fpcw :: (invariant load (s80) from %fixed-stack.0, align 16) | ||
| ; GISEL-I686-NEXT: [[CHS_Fp80_:%[0-9]+]]:rfp80 = CHS_Fp80 [[LD_Fp80m]], implicit-def dead $fpsw | ||
| ; GISEL-I686-NEXT: $fp0 = COPY [[CHS_Fp80_]] | ||
| ; GISEL-I686-NEXT: RET 0, implicit $fp0 | ||
| %1:_(p0) = G_FRAME_INDEX %fixed-stack.0 | ||
| %0:_(s80) = G_LOAD %1(p0) :: (invariant load (s80) from %fixed-stack.0, align 16) | ||
| %2:_(s80) = G_FNEG %0 | ||
| $fp0 = COPY %2(s80) | ||
| RET 0, implicit $fp0 | ||
| ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be doing anything with the context function