Skip to content

[mlir][python] Fix ir.Value type to not break other types #167930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2025
Merged

[mlir][python] Fix ir.Value type to not break other types #167930

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a73948
[mlir][python] Fix ir.Value type to not break other types
nirvedhmeshram Nov 13, 2025
ce590f4
also handle OpResult
nirvedhmeshram Nov 13, 2025
7f40a2c
also handle OpResult
nirvedhmeshram Nov 13, 2025
8ddb894
Merge branch 'main' into fix_binding
nirvedhmeshram Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ static void emitElementAccessors(
type = std::strcmp(kind, "operand") == 0 ? "_ods_ir.Value"
: "_ods_ir.OpResult";
}
if (std::strcmp(kind, "operand") == 0) {
if (std::strcmp(type.c_str(), "_ods_ir.Value") == 0) {
StringRef pythonType = getPythonType(element.constraint.getCppType());
if (!pythonType.empty())
type += "[" + pythonType.str() + "]";
Expand Down Expand Up @@ -473,7 +473,7 @@ static void emitElementAccessors(
if (!element.isVariableLength() || element.isOptional()) {
type = std::strcmp(kind, "operand") == 0 ? "_ods_ir.Value"
: "_ods_ir.OpResult";
if (std::strcmp(kind, "operand") == 0) {
if (std::strcmp(type.c_str(), "_ods_ir.Value") == 0) {
StringRef pythonType = getPythonType(element.constraint.getCppType());
if (!pythonType.empty())
type += "[" + pythonType.str() + "]";
Expand Down
Loading