Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang/include/clang/Sema/SemaARM.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ class SemaARM : public SemaBase {
bool checkTargetClonesAttr(SmallVectorImpl<StringRef> &Params,
SmallVectorImpl<SourceLocation> &Locs,
SmallVectorImpl<SmallString<64>> &NewParams);
bool checkSVETypeSupport(QualType Ty, SourceLocation Loc,
const FunctionDecl *FD,
const llvm::StringMap<bool> &FeatureMap);
};

SemaARM::ArmStreamingType getArmStreamingFnType(const FunctionDecl *FD);
Expand Down
10 changes: 2 additions & 8 deletions clang/lib/Sema/Sema.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2254,16 +2254,10 @@ void Sema::checkTypeSupport(QualType Ty, SourceLocation Loc, ValueDecl *D) {
}

// Don't allow SVE types in functions without a SVE target.
if (Ty->isSVESizelessBuiltinType() && FD && !FD->getType().isNull()) {
if (Ty->isSVESizelessBuiltinType() && FD) {
llvm::StringMap<bool> CallerFeatureMap;
Context.getFunctionFeatureMap(CallerFeatureMap, FD);
if (!Builtin::evaluateRequiredTargetFeatures("sve", CallerFeatureMap)) {
if (!Builtin::evaluateRequiredTargetFeatures("sme", CallerFeatureMap))
Diag(Loc, diag::err_sve_vector_in_non_sve_target) << Ty;
else if (!IsArmStreamingFunction(FD,
/*IncludeLocallyStreaming=*/true))
Diag(Loc, diag::err_sve_vector_in_non_streaming_function) << Ty;
}
ARM().checkSVETypeSupport(Ty, Loc, FD, CallerFeatureMap);
}

if (auto *VT = Ty->getAs<VectorType>();
Expand Down
20 changes: 20 additions & 0 deletions clang/lib/Sema/SemaARM.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1685,4 +1685,24 @@ bool SemaARM::checkTargetClonesAttr(
return false;
}

bool SemaARM::checkSVETypeSupport(QualType Ty, SourceLocation Loc,
const FunctionDecl *FD,
const llvm::StringMap<bool> &FeatureMap) {
if (!Ty->isSVESizelessBuiltinType())
return false;

if (FeatureMap.lookup("sve"))
return false;

// No SVE environment available.
if (!FeatureMap.lookup("sme"))
return Diag(Loc, diag::err_sve_vector_in_non_sve_target) << Ty;

// SVE environment only available to streaming functions.
if (FD && !FD->getType().isNull() &&
!IsArmStreamingFunction(FD, /*IncludeLocallyStreaming=*/true))
return Diag(Loc, diag::err_sve_vector_in_non_streaming_function) << Ty;

return false;
}
} // namespace clang
18 changes: 4 additions & 14 deletions clang/lib/Sema/SemaDecl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9125,20 +9125,10 @@ void Sema::CheckVariableDeclarationType(VarDecl *NewVD) {
const FunctionDecl *FD = cast<FunctionDecl>(CurContext);
llvm::StringMap<bool> CallerFeatureMap;
Context.getFunctionFeatureMap(CallerFeatureMap, FD);

if (!Builtin::evaluateRequiredTargetFeatures("sve", CallerFeatureMap)) {
if (!Builtin::evaluateRequiredTargetFeatures("sme", CallerFeatureMap)) {
Diag(NewVD->getLocation(), diag::err_sve_vector_in_non_sve_target) << T;
NewVD->setInvalidDecl();
return;
} else if (!IsArmStreamingFunction(FD,
/*IncludeLocallyStreaming=*/true)) {
Diag(NewVD->getLocation(),
diag::err_sve_vector_in_non_streaming_function)
<< T;
NewVD->setInvalidDecl();
return;
}
if (ARM().checkSVETypeSupport(T, NewVD->getLocation(), FD,
CallerFeatureMap)) {
NewVD->setInvalidDecl();
return;
}
}

Expand Down
8 changes: 8 additions & 0 deletions clang/lib/Sema/SemaExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4189,6 +4189,14 @@ static bool CheckVectorElementsTraitOperandType(Sema &S, QualType T,
<< ""
<< "__builtin_vectorelements" << T << ArgRange;

if (auto *FD = dyn_cast<FunctionDecl>(S.CurContext)) {
if (T->isSVESizelessBuiltinType()) {
llvm::StringMap<bool> CallerFeatureMap;
S.Context.getFunctionFeatureMap(CallerFeatureMap, FD);
return S.ARM().checkSVETypeSupport(T, Loc, FD, CallerFeatureMap);
}
}

return false;
}

Expand Down
46 changes: 46 additions & 0 deletions clang/test/Sema/AArch64/builtin_vectorelements.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -fsyntax-only -verify %s
// REQUIRES: aarch64-registered-target

#include <arm_sve.h>

__attribute__((target("sve")))
long test_builtin_vectorelements_sve(void) {
return __builtin_vectorelements(svuint8_t);
}

__attribute__((target("sve2p1")))
long test_builtin_vectorelements_sve2p1(void) {
return __builtin_vectorelements(svuint8_t);
}

long test_builtin_vectorelements_no_sve(void) {
// expected-error@+1 {{SVE vector type 'svuint8_t' (aka '__SVUint8_t') cannot be used in a target without sve}}
return __builtin_vectorelements(svuint8_t);
}

__attribute__((target("sme")))
long test_builtin_vectorelements_sme_streaming(void) __arm_streaming {
return __builtin_vectorelements(svuint8_t);
}

__attribute__((target("sme2p1")))
long test_builtin_vectorelements_sme2p1_streaming(void) __arm_streaming {
return __builtin_vectorelements(svuint8_t);
}

__attribute__((target("sme")))
long test_builtin_vectorelements_sme(void) {
// expected-error@+1 {{SVE vector type 'svuint8_t' (aka '__SVUint8_t') cannot be used in a non-streaming function}}
return __builtin_vectorelements(svuint8_t);
}

__attribute__((target("sve,sme")))
long test_builtin_vectorelements_sve_sme_streaming_compatible(void) __arm_streaming_compatible {
return __builtin_vectorelements(svuint8_t);
}

__attribute__((target("sme")))
long test_builtin_vectorelements_sme_streaming_compatible(void) __arm_streaming_compatible {
// expected-error@+1 {{SVE vector type 'svuint8_t' (aka '__SVUint8_t') cannot be used in a non-streaming function}}
return __builtin_vectorelements(svuint8_t);
}
Loading