Skip to content

[MLIR] Fix affine SSA id parser for values with numbers #168175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −7
Open

[MLIR] Fix affine SSA id parser for values with numbers #168175

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c217b2
[MLIR] Fix affine SSA id parser for values with numbers
jeonghm9764 Nov 15, 2025
05d8297
[MLIR] Add test for the fix
jeonghm9764 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions mlir/lib/AsmParser/AffineParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,13 +311,6 @@ AffineExpr AffineParser::parseSSAIdExpr(bool isSymbol) {
if (getToken().isNot(Token::percent_identifier))
return emitWrongTokenError("expected ssa identifier"), nullptr;
auto name = getTokenSpelling();
// Check if we already parsed this SSA id.
for (auto entry : dimsAndSymbols) {
if (entry.first == name) {
consumeToken(Token::percent_identifier);
return entry.second;
}
}
// Parse the SSA id and add an AffineDim/SymbolExpr to represent it.
if (parseElement(isSymbol))
return nullptr;
Expand Down