Skip to content

[CIR][X86] Add NYI diagnostic for __builtin_ia32_sqrtps #168320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[CIR][X86] Add NYI diagnostic for __builtin_ia32_sqrtps #168320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31f4bce
CIR: Fix X86 builtin sqrt handling and cleanup max() unsigned cast
Priyanshu3820 Nov 17, 2025
7f3f249
CIR: Add x86 sqrt builtin test
Priyanshu3820 Nov 17, 2025
f4139a9
CIR: Narrow sqrt builtin NYI changes
Priyanshu3820 Nov 18, 2025
0498749
CIR: Add NYI diagnostic for __builtin_ia32_sqrtps
Priyanshu3820 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clang/lib/CIR/CodeGen/CIRGenBuiltinX86.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,10 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned builtinID,
case X86::BI__builtin_ia32_sqrtpd:
case X86::BI__builtin_ia32_sqrtps256:
case X86::BI__builtin_ia32_sqrtps:
CGF.CGM.getDiags().Report(E->getExprLoc(), diag::err_cir_nyi)
<< "__builtin_ia32_sqrtps";
return CIRGenFunction::IgnoreValue();

case X86::BI__builtin_ia32_sqrtph256:
case X86::BI__builtin_ia32_sqrtph:
case X86::BI__builtin_ia32_sqrtph512:
Expand Down
3 changes: 2 additions & 1 deletion clang/lib/CIR/CodeGen/CIRGenCleanup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

#include "clang/CIR/MissingFeatures.h"

#include<algorithm>
using namespace clang;
using namespace clang::CIRGen;

Expand Down Expand Up @@ -97,7 +98,7 @@ EHScopeStack::getInnermostActiveNormalCleanup() const {
char *EHScopeStack::allocate(size_t size) {
size = llvm::alignTo(size, ScopeStackAlignment);
if (!startOfBuffer) {
unsigned capacity = llvm::PowerOf2Ceil(std::max(size, 1024ul));
unsigned capacity = llvm::PowerOf2Ceil(std::max(static_cast<unsigned long>(size), 1024ul));
startOfBuffer = std::make_unique<char[]>(capacity);
startOfData = endOfBuffer = startOfBuffer.get() + capacity;
} else if (static_cast<size_t>(startOfData - startOfBuffer.get()) < size) {
Expand Down
14 changes: 14 additions & 0 deletions clang/test/CIR/CodeGen/X86/builtin-x86-sqrt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// RUN: not %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir -o - %s 2>&1 | FileCheck %s

// Minimal stand-in for the SSE vector type.
typedef float __m128 __attribute__((__vector_size__(16)));

// Declare the builtin explicitly so we don't need headers.
__m128 __builtin_ia32_sqrtps(__m128);

__m128 test_sqrtps(__m128 a) {
return __builtin_ia32_sqrtps(a);
}

// CHECK: error: ClangIR code gen Not Yet Implemented: CIR lowering for x86 sqrt builtins is not implemented yet
// CHECK: error: ClangIR code gen Not Yet Implemented: unimplemented builtin call: __builtin_ia32_sqrtps
Loading