Skip to content

[CI] Gracefully Fail when Job Completion Timestamp is None #168457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

[CI] Gracefully Fail when Job Completion Timestamp is None #168457

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
197b720
[CI] Gracefully Fail when Job Completion Timestamp is None
boomanaiden154 Nov 17, 2025
4c04627
fix
boomanaiden154 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .ci/metrics/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,13 @@ def github_get_metrics(
started_at = job.started_at
completed_at = job.completed_at

if completed_at is None:
logging.info(
"Workflow {} is marked completed but has a job without a "
Copy link
Contributor

@cmtice cmtice Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the curly braces for?

Copy link
Contributor Author

@boomanaiden154 boomanaiden154 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was meant to point to an ID through an fstring. Fixed now.

"completion timestamp."
)
continue

# GitHub API can return results where the started_at is slightly
# later then the created_at (or completed earlier than started).
# This would cause a -23h59mn delta, which will show up as +24h
Expand Down
Loading