Skip to content

[libc++][NFC] Refactor __request_unbuffered_mode #168950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[libc++][NFC] Refactor __request_unbuffered_mode #168950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions libcxx/include/fstream
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,14 +419,12 @@ private:
// If the file is already open, switch to unbuffered mode. Otherwise, record
// the request to use unbuffered mode so that we use that mode when we
// eventually open the file.
_LIBCPP_HIDE_FROM_ABI void __request_unbuffered_mode(char_type* __s, streamsize __n) {
if (__cm_ == __no_io_operations && __s == nullptr && __n == 0) {
if (__file_) {
std::setbuf(__file_, nullptr);
__cm_ = 0;
} else {
__cm_ = __no_io_operations | __use_unbuffered_io;
}
_LIBCPP_HIDE_FROM_ABI void __request_unbuffered_mode() {
if (__file_) {
std::setbuf(__file_, nullptr);
__cm_ = 0;
} else {
__cm_ = __no_io_operations | __use_unbuffered_io;
}
}

Expand Down Expand Up @@ -934,7 +932,9 @@ template <class _CharT, class _Traits>
basic_streambuf<_CharT, _Traits>* basic_filebuf<_CharT, _Traits>::setbuf(char_type* __s, streamsize __n) {
this->setg(nullptr, nullptr, nullptr);
this->setp(nullptr, nullptr);
__request_unbuffered_mode(__s, __n);
// Calling setbuf(nullptr, 0) before any i/o operation switches the stream to unbuffered mode
if (__cm_ == __no_io_operations && __s == nullptr && __n == 0)
__request_unbuffered_mode();
if (__owns_eb_)
delete[] __extbuf_;
if (__owns_ib_)
Expand Down
Loading