Skip to content

[lldb] Add assert to NonNullSharedPtr move constructor #168979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JDevlieghere merged 1 commit into from
Nov 21, 2025
Merged

[lldb] Add assert to NonNullSharedPtr move constructor #168979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lldb/include/lldb/Utility/NonNullSharedPtr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,14 @@ template <typename T> class NonNullSharedPtr : private std::shared_ptr<T> {
public:
NonNullSharedPtr(const std::shared_ptr<T> &t)
: Base(t ? t : std::make_shared<T>()) {
assert(t && "NonNullSharedPtr initialized from NULL shared_ptr");
assert(t && "NonNullSharedPtr constructed from nullptr");
}

NonNullSharedPtr(std::shared_ptr<T> &&t)
: Base(t ? std::move(t) : std::make_shared<T>()) {
// Can't assert on t as it's been moved-from.
NonNullSharedPtr(std::shared_ptr<T> &&t) : Base(std::move(t)) {
const auto b = static_cast<bool>(*this);
assert(b && "NonNullSharedPtr constructed from nullptr");
if (!b)
Base::operator=(std::make_shared<T>());
}

NonNullSharedPtr(const NonNullSharedPtr &other) : Base(other) {}
Expand Down
Loading