Skip to content

[LTO] Use a range-based for loop (NFC) #169000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazutakahirata merged 2 commits into from
Nov 21, 2025
Merged

[LTO] Use a range-based for loop (NFC) #169000

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e491511
[LTO] Use a range-based for loop (NFC)
kazutakahirata Nov 20, 2025
2b5f78c
Address a comment.
kazutakahirata Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions llvm/lib/LTO/LTOModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,13 +620,11 @@ void LTOModule::parseSymbols() {
}

// make symbols for all undefines
for (StringMap<NameAndAttributes>::iterator u =_undefines.begin(),
e = _undefines.end(); u != e; ++u) {
for (const auto &[Key, Value] : _undefines) {
// If this symbol also has a definition, then don't make an undefine because
// it is a tentative definition.
if (_defines.count(u->getKey())) continue;
NameAndAttributes info = u->getValue();
_symbols.push_back(info);
if (!_defines.count(Key))
_symbols.push_back(Value);
}
}

Expand Down