[ORC] Fix obj-imageinfo.S on X86 Darwin with Internal Shell #169104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d464c99 fixes this test on AArch64 Darwin, but I did not realize that there was another X86 version of the test. This patch also updates the X86 version of the test in a similar manner.
boomanaiden154
changed the title
🐧 Linux x64 Test Results
|
lhames
approved these changes
Nov 21, 2025
Contributor
lhames
left a comment
lhames
left a comment
There was a problem hiding this comment.
LGTM. Thanks again @boomanaiden154!
aadeshps-mcw
pushed a commit
to aadeshps-mcw/llvm-project
that referenced
this pull request
Nov 26, 2025
) d464c99 fixes this test on AArch64 Darwin, but I did not realize that there was another X86 version of the test. This patch also updates the X86 version of the test in a similar manner.
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Nov 26, 2025
) d464c99 fixes this test on AArch64 Darwin, but I did not realize that there was another X86 version of the test. This patch also updates the X86 version of the test in a similar manner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d464c99 fixes this test on AArch64 Darwin, but I did not realize that there was another X86 version of the test. This patch also updates the X86 version of the test in a similar manner.