Skip to content

[libc++] Refactor optional constructor tests #169203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[libc++] Refactor optional constructor tests #169203

wants to merge 17 commits into from

Conversation

@smallp-o-p
Copy link
Contributor

@smallp-o-p smallp-o-p commented Nov 23, 2025 •
edited
Loading

  • Reformat, and refactor as much as possible tests in utilities/optional/optional.object/optional.object.ctor to be simpler and more similar to the pattern newer tests have.
  • This consequently should increase constexpr test coverage by some amount.
  • The intent of the tests should not have been changed, meaning they should be testing the same things as they did before this PR.
  • This PR also unlocks runtime constructor tests for std::optional<T&> that were missed in the original optional<T&> PR.

@smallp-o-p smallp-o-p requested a review from a team as a code owner November 23, 2025 08:03
@smallp-o-p
Copy link
Contributor Author

smallp-o-p commented Nov 23, 2025

...Should I make a separate PR just for formatting?

@Zingam
Copy link
Contributor

Zingam commented Nov 23, 2025

...Should I make a separate PR just for formatting?

Definitely. Commit and rebase.

@smallp-o-p smallp-o-p mentioned this pull request Nov 23, 2025
Merged
@smallp-o-p
Copy link
Contributor Author

smallp-o-p commented Nov 23, 2025

...Should I make a separate PR just for formatting?

Definitely. Commit and rebase.

Done: #169231

frederick-vs-ja pushed a commit that referenced this pull request Nov 27, 2025
@smallp-o-p
[libc++] Reformat optional constructor tests (#169231)
f6712b6 
- Mass-reformat tests in
`std/utilities/optional/optional.object/optional.object.ctor` and
rearrange header `#include`s
- No functional changes
- Prelude for #169203
@smallp-o-p smallp-o-p force-pushed the refactor-optional-ctor-tests branch from 0c54f09 to bcf9f55 Compare November 27, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smallp-o-p @Zingam