-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[LLD][COFF] Prefetch inputs early-on to improve link times #169224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aganea
wants to merge
1
commit into
llvm:main
Choose a base branch
from
aganea:feat/lld_coff_prefetching
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1023,6 +1023,32 @@ void mapped_file_region::unmapImpl() { | |
|
|
||
| void mapped_file_region::dontNeedImpl() {} | ||
|
|
||
| void mapped_file_region::willNeedImpl() { | ||
| #if (_WIN32_WINNT < _WIN32_WINNT_WIN8) | ||
| typedef struct _WIN32_MEMORY_RANGE_ENTRY { | ||
| PVOID VirtualAddress; | ||
| SIZE_T NumberOfBytes; | ||
| } WIN32_MEMORY_RANGE_ENTRY, *PWIN32_MEMORY_RANGE_ENTRY; | ||
| #endif | ||
|
|
||
| HMODULE kernelM = llvm::sys::windows::loadSystemModuleSecure(L"kernel32.dll"); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is where the version is likely more useful. In the case of the minimum deployment version being >7, we should prefer static linking IMO. But, I know that is more challenging and potentially not as valuable to invest in, so more of a passing comment. |
||
| if (kernelM) { | ||
| // PrefetchVirtualMemory is only available on Windows 8 and later. Since we | ||
| // still support compilation on Windows 7, we load the function dynamically. | ||
| typedef BOOL(WINAPI * PrefetchVirtualMemory_t)( | ||
| HANDLE hProcess, ULONG_PTR NumberOfEntries, | ||
| _In_reads_(NumberOfEntries) PWIN32_MEMORY_RANGE_ENTRY VirtualAddresses, | ||
| ULONG Flags); | ||
| static const auto pfnPrefetchVirtualMemory = | ||
| (PrefetchVirtualMemory_t)::GetProcAddress(kernelM, | ||
| "PrefetchVirtualMemory"); | ||
| if (pfnPrefetchVirtualMemory) { | ||
| WIN32_MEMORY_RANGE_ENTRY Range{Mapping, Size}; | ||
| pfnPrefetchVirtualMemory(::GetCurrentProcess(), 1, &Range, 0); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| std::error_code mapped_file_region::sync() const { | ||
| if (!::FlushViewOfFile(Mapping, Size)) | ||
| return mapWindowsError(GetLastError()); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have many of these cases? I wonder if we should sink this into LLVM with a check for the type definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're dlopen'ing and rolling our own function prototype anyway below, maybe we should just define this struct unconditionally (with a name that doesn't clash with the windows header)?