Revert "[libcxx][ci] Temporarily disable ARM jobs" #169352
Merged
+57
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 840a43b.
DavidSpickett
added
the
skip-precommit-approval
llvmbot
added
the
libc++
Member
|
@llvm/pr-subscribers-libcxx Author: David Spickett (DavidSpickett) ChangesReverts llvm/llvm-project#169318 Our builders are back online. I see them picking up existing jobs. Full diff: https://github.com/llvm/llvm-project/pull/169352.diff 1 Files Affected:
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index 8b77a06323e3d..2ac69c38ebffa 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -33,64 +33,63 @@ definitions:
- "**/CMakeOutput.log"
steps:
-# Linaro's ARM builders are temporarily offline.
-#- group: ARM
-# steps:
-# - label: AArch64
-# command: libcxx/utils/ci/run-buildbot aarch64
-# agents:
-# queue: libcxx-builders-linaro-arm
-# arch: aarch64
-# <<: *common
-#
-# - label: AArch64 -fno-exceptions
-# command: libcxx/utils/ci/run-buildbot aarch64-no-exceptions
-# agents:
-# queue: libcxx-builders-linaro-arm
-# arch: aarch64
-# <<: *common
-#
-# - label: Armv8
-# command: libcxx/utils/ci/run-buildbot armv8
-# agents:
-# queue: libcxx-builders-linaro-arm
-# arch: armv8l
-# <<: *common
-#
-# - label: Armv8 -fno-exceptions
-# command: libcxx/utils/ci/run-buildbot armv8-no-exceptions
-# agents:
-# queue: libcxx-builders-linaro-arm
-# arch: armv8l
-# <<: *common
-#
-# - label: Armv7
-# command: libcxx/utils/ci/run-buildbot armv7
-# agents:
-# queue: libcxx-builders-linaro-arm
-# arch: armv8l
-# <<: *common
-#
-# - label: Armv7 -fno-exceptions
-# command: libcxx/utils/ci/run-buildbot armv7-no-exceptions
-# agents:
-# queue: libcxx-builders-linaro-arm
-# arch: armv8l
-# <<: *common
-#
-# - label: Armv7-M picolibc
-# command: libcxx/utils/ci/run-buildbot armv7m-picolibc
-# agents:
-# queue: libcxx-builders-linaro-arm
-# arch: aarch64
-# <<: *common
-#
-# - label: Armv7-M picolibc -fno-exceptions
-# command: libcxx/utils/ci/run-buildbot armv7m-picolibc-no-exceptions
-# agents:
-# queue: libcxx-builders-linaro-arm
-# arch: aarch64
-# <<: *common
+- group: ARM
+ steps:
+ - label: AArch64
+ command: libcxx/utils/ci/run-buildbot aarch64
+ agents:
+ queue: libcxx-builders-linaro-arm
+ arch: aarch64
+ <<: *common
+
+ - label: AArch64 -fno-exceptions
+ command: libcxx/utils/ci/run-buildbot aarch64-no-exceptions
+ agents:
+ queue: libcxx-builders-linaro-arm
+ arch: aarch64
+ <<: *common
+
+ - label: Armv8
+ command: libcxx/utils/ci/run-buildbot armv8
+ agents:
+ queue: libcxx-builders-linaro-arm
+ arch: armv8l
+ <<: *common
+
+ - label: Armv8 -fno-exceptions
+ command: libcxx/utils/ci/run-buildbot armv8-no-exceptions
+ agents:
+ queue: libcxx-builders-linaro-arm
+ arch: armv8l
+ <<: *common
+
+ - label: Armv7
+ command: libcxx/utils/ci/run-buildbot armv7
+ agents:
+ queue: libcxx-builders-linaro-arm
+ arch: armv8l
+ <<: *common
+
+ - label: Armv7 -fno-exceptions
+ command: libcxx/utils/ci/run-buildbot armv7-no-exceptions
+ agents:
+ queue: libcxx-builders-linaro-arm
+ arch: armv8l
+ <<: *common
+
+ - label: Armv7-M picolibc
+ command: libcxx/utils/ci/run-buildbot armv7m-picolibc
+ agents:
+ queue: libcxx-builders-linaro-arm
+ arch: aarch64
+ <<: *common
+
+ - label: Armv7-M picolibc -fno-exceptions
+ command: libcxx/utils/ci/run-buildbot armv7m-picolibc-no-exceptions
+ agents:
+ queue: libcxx-builders-linaro-arm
+ arch: aarch64
+ <<: *common
- group: AIX
steps:
|
Collaborator
Author
|
I'm going to enable auto-merge here as a reminder to me to clean up any test problems we missed during the downtime. If there are no issues, it'll merge and all new CI jobs will then have ARM included again. |
Collaborator
Author
|
...did not realise that if I had no libcxx changes it wouldn't run the Buildkite part. Well, as usual, ping me if you have problems. |
aadeshps-mcw
pushed a commit
to aadeshps-mcw/llvm-project
that referenced
this pull request
Nov 26, 2025
Reverts llvm#169318 Our builders are back online. I see them picking up existing jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #169318
Our builders are back online. I see them picking up existing jobs.