Skip to content

[lldb][NFC] Remove code dupl in favour of a named variable in UnwindAssemblyInstEmulation #169369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2025
Merged

[lldb][NFC] Remove code dupl in favour of a named variable in UnwindAssemblyInstEmulation #169369

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e4b119
[lldb][NFC] Remove code dupl in favour of a named variable in UnwindA…
felipepiovezan Nov 24, 2025
82f8eba
fixup! remove auto in favour of guessing the type
felipepiovezan Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,11 +212,10 @@ bool UnwindAssemblyInstEmulation::GetNonCallSiteUnwindPlanFromAssembly(
if (m_curr_row_modified) {
// Save the modified row if we don't already have a CFI row in the
// current address
if (saved_unwind_states.count(current_offset +
inst->GetOpcode().GetByteSize()) == 0) {
m_state.row.SetOffset(current_offset + inst->GetOpcode().GetByteSize());
saved_unwind_states.emplace(
current_offset + inst->GetOpcode().GetByteSize(), m_state);
auto next_inst_offset = current_offset + inst->GetOpcode().GetByteSize();
Copy link
Contributor

@da-viper da-viper Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use const type instead of auto.

Copy link
Contributor Author

@felipepiovezan felipepiovezan Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad, but it is the guideline

if (saved_unwind_states.count(next_inst_offset) == 0) {
m_state.row.SetOffset(next_inst_offset);
saved_unwind_states.emplace(next_inst_offset, m_state);
}
}
}
Expand Down
Loading