Skip to content

[bazel] Revert 539d5d40fd42 and 223314bc04d1 #169412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −15
Open

[bazel] Revert 539d5d40fd42 and 223314bc04d1 #169412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
539d5d4
Revert "[bazel] Fully port 3773bbe9e7916ec89fb3e3cd02e29c54cabac82b (…
googlewalt Nov 24, 2025
223314b
Revert "[bazel] Port 3773bbe9e7916ec89fb3e3cd02e29c54cabac82b"
googlewalt Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/lib/Frontend/CompilerInvocation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@
#include <vector>

using namespace clang;
using namespace driver;
Copy link
Member

@jyknight jyknight Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should drop this part from the revert.

using namespace options;
using namespace llvm::opt;

Expand Down
10 changes: 1 addition & 9 deletions utils/bazel/llvm-project-overlay/clang/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1371,7 +1371,6 @@ cc_library(
":analysis",
":ast",
":basic",
":driver",
":frontend",
":index",
"//llvm:Option",
Expand Down Expand Up @@ -1519,11 +1518,9 @@ cc_library(
includes = ["include"],
deps = [
":basic",
":config",
":driver_options_inc_gen",
":static_analyzer_checkers_gen",
"//llvm:Option",
"//llvm:Support",
],
)

Expand Down Expand Up @@ -1563,11 +1560,9 @@ cc_library(
":basic",
":config",
":driver_options_inc_gen",
":frontend",
":lex",
":options",
":parse",
":serialization",
":static_analyzer_checkers_gen",
"//llvm:BinaryFormat",
"//llvm:FrontendDebug",
Expand Down Expand Up @@ -1719,6 +1714,7 @@ cc_library(
":ast",
":basic",
":config",
":driver",
":driver_options_inc_gen",
":edit",
":lex",
Expand Down Expand Up @@ -2051,7 +2047,6 @@ cc_library(
":frontend",
":index",
":lex",
":options",
":rewrite",
":sema",
":tooling",
Expand Down Expand Up @@ -2084,7 +2079,6 @@ cc_plugin_library(
":frontend",
":index",
":lex",
":options",
":rewrite",
":sema",
":tooling",
Expand Down Expand Up @@ -2126,7 +2120,6 @@ cc_binary(
":basic",
":codegen",
":config",
":driver",
":frontend",
":index",
":lex",
Expand Down Expand Up @@ -2243,7 +2236,6 @@ cc_binary(
deps = [
":basic",
":diagnostic_defs_gen",
":driver",
":frontend",
":lex",
":sema",
Expand Down
4 changes: 0 additions & 4 deletions utils/bazel/llvm-project-overlay/clang/unittests/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ cc_test(
"//clang:ast",
"//clang:basic",
"//clang:codegen",
"//clang:driver",
"//clang:driver_options_inc_gen",
"//clang:frontend",
"//clang:frontend_tool",
Expand Down Expand Up @@ -339,7 +338,6 @@ cc_test(
"//clang:ast",
"//clang:ast_matchers",
"//clang:basic",
"//clang:driver",
"//clang:frontend",
"//clang:lex",
"//clang:parse",
Expand Down Expand Up @@ -518,7 +516,6 @@ cc_test(
deps = [
"//clang:ast",
"//clang:basic",
"//clang:driver",
"//clang:frontend",
"//clang:lex",
"//clang:testing",
Expand Down Expand Up @@ -723,7 +720,6 @@ cc_test(
deps = [
"//clang:ast_matchers",
"//clang:basic",
"//clang:driver",
"//clang:frontend",
"//clang:lex",
"//clang:parse",
Expand Down
1 change: 0 additions & 1 deletion utils/bazel/llvm-project-overlay/lldb/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,6 @@ cc_library(
":Utility",
":Version",
"//clang:codegen",
"//clang:driver",
"//clang:frontend",
"//clang:serialization",
"//llvm:Support",
Expand Down
1 change: 0 additions & 1 deletion utils/bazel/llvm-project-overlay/lldb/source/Plugins/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ cc_library(
"//clang:frontend",
"//clang:frontend_rewrite",
"//clang:lex",
"//clang:options",
"//clang:parse",
"//clang:rewrite",
"//clang:sema",
Expand Down