Skip to content

Conversation

@arsenm
Copy link
Contributor

@arsenm arsenm commented Nov 25, 2025

This hasn't been strictly necessary since c897c13.
Practically this makes little difference; we still enable IPRA
by default which implies this option. By removing this explicit
force, -enable-ipra=0 has the expected change in the pass pipeline
to remove the DummyCGSCC runs.

The fixme the comment refers to was removed.
This hasn't been strictly necessary since c897c13.
Practically this makes little difference; we still enable IPRA
by default which implies this option. By removing this explicit
force, -enable-ipra=0 has the expected change in the pass pipeline
to remove the DummyCGSCC runs.
Copy link
Contributor Author

arsenm commented Nov 25, 2025

@llvmbot
Copy link
Member

llvmbot commented Nov 25, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Matt Arsenault (arsenm)

Changes

This hasn't been strictly necessary since c897c13.
Practically this makes little difference; we still enable IPRA
by default which implies this option. By removing this explicit
force, -enable-ipra=0 has the expected change in the pass pipeline
to remove the DummyCGSCC runs.


Full diff: https://github.com/llvm/llvm-project/pull/169522.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp (-4)
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
index 23ca4dcc009c8..e5a35abe6da6b 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
@@ -1226,10 +1226,6 @@ class GCNPassConfig final : public AMDGPUPassConfig {
 public:
   GCNPassConfig(TargetMachine &TM, PassManagerBase &PM)
       : AMDGPUPassConfig(TM, PM) {
-    // It is necessary to know the register usage of the entire call graph.  We
-    // allow calls without EnableAMDGPUFunctionCalls if they are marked
-    // noinline, so this is always required.
-    setRequiresCodeGenSCCOrder(true);
     substitutePass(&PostRASchedulerID, &PostMachineSchedulerID);
   }
 

Base automatically changed from users/arsenm/amdgpu/remove-DummyCGSCCPass-use to main November 25, 2025 17:53
@arsenm arsenm enabled auto-merge (squash) November 25, 2025 18:23
@arsenm arsenm disabled auto-merge November 25, 2025 18:23
@arsenm arsenm merged commit 1d30ae6 into main Nov 25, 2025
13 of 14 checks passed
@arsenm arsenm deleted the users/arsenm/amdgpu/stop-forcing-codegen-scc-order branch November 25, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants