Skip to content

[MapVector] Introduce {keys,values} iterators #169675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artagnon merged 5 commits into from
Dec 1, 2025
Merged

[MapVector] Introduce {keys,values} iterators #169675

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53ff293
[MapVector] Introduce {keys,values} iterator, use in VPlan
artagnon Nov 26, 2025
4dadc48
[MapVector] Use make_(first|second)_range
artagnon Nov 26, 2025
c7c9349
[MapVector] Reorder keys, values
artagnon Dec 1, 2025
81d441c
[VPlan] Revert MapVector changes
artagnon Dec 1, 2025
9328f0d
[MapVector] s/inline//
artagnon Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions llvm/include/llvm/ADT/MapVector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ class MapVector {
return try_emplace_impl(Key).first->second;
}

[[nodiscard]] inline auto keys() { return make_first_range(Vector); }
[[nodiscard]] inline auto keys() const { return make_first_range(Vector); }
[[nodiscard]] inline auto values() { return make_second_range(Vector); }
[[nodiscard]] inline auto values() const { return make_second_range(Vector); }

// Returns a copy of the value. Only allowed if ValueT is copyable.
[[nodiscard]] ValueT lookup(const KeyT &Key) const {
static_assert(std::is_copy_constructible_v<ValueT>,
Expand Down
18 changes: 18 additions & 0 deletions llvm/unittests/ADT/MapVectorTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,24 @@ TEST(MapVectorTest, AtTest) {
EXPECT_EQ(ConstMV.at(1), 12);
}

TEST(MapVectorTest, KeysValuesIterator) {
MapVector<int, int> MV;

MV.insert(std::make_pair(1, 11));
MV.insert(std::make_pair(2, 12));
MV.insert(std::make_pair(3, 13));
MV.insert(std::make_pair(4, 14));
MV.insert(std::make_pair(5, 15));
MV.insert(std::make_pair(6, 16));

EXPECT_THAT(MV.keys(), testing::ElementsAre(1, 2, 3, 4, 5, 6));
EXPECT_THAT(MV.values(), testing::ElementsAre(11, 12, 13, 14, 15, 16));

const MapVector<int, int> &ConstMV = MV;
EXPECT_THAT(ConstMV.keys(), testing::ElementsAre(1, 2, 3, 4, 5, 6));
EXPECT_THAT(ConstMV.values(), testing::ElementsAre(11, 12, 13, 14, 15, 16));
}

template <class IntType> struct MapVectorMappedTypeTest : ::testing::Test {
using int_type = IntType;
};
Expand Down