[CI] Add checkmark emojis for passing builds

[boomanaiden154]

This better matches the code formatter and I personally find the visual indication valuable when I am scrolling/glancing at a comment.

[llvmbot]

@llvm/pr-subscribers-infrastructure

Author: Aiden Grossman (boomanaiden154)

Changes

This better matches the code formatter and I personally find the visual indication valuable when I am scrolling/glancing at a comment.

---

Full diff: https://github.com/llvm/llvm-project/pull/170183.diff

2 Files Affected:

• (modified) .ci/generate_test_report_lib.py (+4-2)
• (modified) .ci/generate_test_report_lib_test.py (+4-2)

diff --git a/.ci/generate_test_report_lib.py b/.ci/generate_test_report_lib.py
index ce8262f0dc73f..10529c26ec337 100644
--- a/.ci/generate_test_report_lib.py
+++ b/.ci/generate_test_report_lib.py
@@ -184,8 +184,8 @@ def generate_report(
         if return_code == 0:
             report.extend(
                 [
-                    "The build succeeded and no tests ran. This is expected in some "
-                    "build configurations."
+                    ":white_check_mark: The build succeeded and no tests ran. "
+                    "This is expected in some build configurations."
                 ]
             )
         else:
@@ -272,6 +272,8 @@ def plural(num_tests):
                 ]
             )
             report.extend(_format_failures(ninja_failures, failure_explanations))
+    else:
+        report.extend(["", ":white_check_mark: The build succeeded and all tests passed."])
 
     if failures or return_code != 0:
         report.extend(["", UNRELATED_FAILURES_STR])
diff --git a/.ci/generate_test_report_lib_test.py b/.ci/generate_test_report_lib_test.py
index 341cf3037b921..182af1d52641a 100644
--- a/.ci/generate_test_report_lib_test.py
+++ b/.ci/generate_test_report_lib_test.py
@@ -194,7 +194,7 @@ def test_title_only(self):
                 """\
                 # Foo
 
-                The build succeeded and no tests ran. This is expected in some build configurations."""
+                :white_check_mark: The build succeeded and no tests ran. This is expected in some build configurations."""
             ),
         )
 
@@ -308,7 +308,9 @@ def test_no_failures(self):
                     """\
               # Foo
 
-              * 1 test passed"""
+              * 1 test passed
+              
+              :white_check_mark: The build succeeded and all tests passed."""
                 )
             ),
         )

[github-actions]

✅ With the latest revision this PR passed the Python code formatter.

[cmtice]

Do you plan on any emojis for failed builds/tests? Maybe a red "x"?

[boomanaiden154]

Do you plan on any emojis for failed builds/tests? Maybe a red "x"?

That's a good idea. I'll put it on the list. We might want to stick to what the code formatting action does for now and use ⚠️ rather than something like ❌, but either one should work.