[flang][runtime] Clean up C++ style & usage #170227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent patch to descriptor.cpp added some code whose style isn't conforming with the rest of the file (or the runtime). We always use braces around initializations and nested statements, and don't indent "case" lines any more than their "switch". Further, it dumps a rank 0 descriptor as just "scalar", which is fine as an interpretation of the rank but should not entirely replace the rank in the dump output.
valerydmit
approved these changes
Dec 2, 2025
Contributor
valerydmit
left a comment
valerydmit
left a comment
There was a problem hiding this comment.
Thanks Peter for letting me know about flang-rt specific style requirements.
Contributor
|
Peter, will you mind if I take these changes for a reapply of the original patch? |
Contributor
Author
Okay by me. |
valerydmit
added a commit
to valerydmit/llvm-project
that referenced
this pull request
Dec 2, 2025
valerydmit
added a commit
that referenced
this pull request
Dec 4, 2025
…extension. (#170389) This is a reapply the original patch (#169137) with the flang-rt unit test changes limiting it to linux platform only. Additionally accommodated style changes from Peter Klausler (#170227) show_descriptor intrinsic prints details of a descriptor (extended Fortran pointer). It accepts a descriptor for any type and rank, including scalars. Requires use of flang_debug module. Example: ``` program test use flang_debug implicit none integer :: a(4) = (/ 1,3,5,7 /) call show_descriptor(a(1:3)) end program test ``` and its output: ``` Descriptor @ 0x7ffe01ec6a98: base_addr 0x563b7035103c elem_len 4 version 20240719 rank 1 type 9 "INTEGER(kind=4)" attribute 0 extra 0 addendum 0 alloc_idx 0 ```
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
…extension. (llvm#170389) This is a reapply the original patch (llvm#169137) with the flang-rt unit test changes limiting it to linux platform only. Additionally accommodated style changes from Peter Klausler (llvm#170227) show_descriptor intrinsic prints details of a descriptor (extended Fortran pointer). It accepts a descriptor for any type and rank, including scalars. Requires use of flang_debug module. Example: ``` program test use flang_debug implicit none integer :: a(4) = (/ 1,3,5,7 /) call show_descriptor(a(1:3)) end program test ``` and its output: ``` Descriptor @ 0x7ffe01ec6a98: base_addr 0x563b7035103c elem_len 4 version 20240719 rank 1 type 9 "INTEGER(kind=4)" attribute 0 extra 0 addendum 0 alloc_idx 0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent patch to descriptor.cpp added some code whose style isn't conforming with the rest of the file (or the runtime). We always use braces around initializations and nested statements, and don't indent "case" lines any more than their "switch". Further, it dumps a rank 0 descriptor as just "scalar", which is fine as an interpretation of the rank but should not entirely replace the rank in the dump output.