Skip to content

[Clang] Fix PPChainedCallbacks::EmbedFileNotFound() #170293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cofibrant merged 3 commits into from
Dec 3, 2025
Merged

[Clang] Fix PPChainedCallbacks::EmbedFileNotFound() #170293

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a2ab1b
[Clang] Fix `PPChainedCallbacks::EmbedFileNotFound()`
cofibrant Dec 2, 2025
61166af
Add test case
cofibrant Dec 2, 2025
901a4ed
Fix nits
cofibrant Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clang/include/clang/Lex/PPCallbacks.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,10 +499,10 @@ class PPChainedCallbacks : public PPCallbacks {
}

bool EmbedFileNotFound(StringRef FileName) override {
bool Skip = First->FileNotFound(FileName);
bool Skip = First->EmbedFileNotFound(FileName);
// Make sure to invoke the second callback, no matter if the first already
// returned true to skip the file.
Skip |= Second->FileNotFound(FileName);
Skip |= Second->EmbedFileNotFound(FileName);
return Skip;
}

Expand Down
Loading