[Github][CI] Make premerge upload results on Linux and Windows #170414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Dec 3, 2025
Now that the issue-write workflow can support writing comments from multiple files, make the premerge workflow write out comments from both x86_64 Linux and Windows. AArch64 Linux right now is left out as the premerge advisor does not currently support it. Pull Request: llvm#170414
Member
|
@llvm/pr-subscribers-infrastructure Author: Aiden Grossman (boomanaiden154) ChangesNow that the issue-write workflow can support writing comments from Full diff: https://github.com/llvm/llvm-project/pull/170414.diff 2 Files Affected:
diff --git a/.ci/premerge_advisor_explain.py b/.ci/premerge_advisor_explain.py
index 155e91bef55f8..bd65eb3d1588b 100644
--- a/.ci/premerge_advisor_explain.py
+++ b/.ci/premerge_advisor_explain.py
@@ -129,7 +129,8 @@ def main(
# If the job succeeds and there is not an existing comment, we
# should not write one to reduce noise.
comments = []
- with open("comments", "w") as comment_file_handle:
+ comments_file_name = f"comments-{platform.system()}-{platform.machine()}"
+ with open(comments_file_name, "w") as comment_file_handle:
json.dump(comments, comment_file_handle)
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 10f7f6a827b30..4ea5397edbeac 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -124,9 +124,9 @@ jobs:
if: ${{ always() && !startsWith(matrix.runs-on, 'depot-ubuntu-24.04-arm') }}
continue-on-error: true
with:
- name: workflow-args
+ name: workflow-args-x86-linux
path: |
- comments
+ comments-Linux-x86_64
premerge-checks-windows:
name: Build and Test Windows
@@ -185,6 +185,14 @@ jobs:
path: artifacts/
retention-days: 5
include-hidden-files: 'true'
+ - name: Upload Comment
+ uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
+ if: always()
+ continue-on-error: true
+ with:
+ name: workflow-args-windows
+ path: |
+ comments-Windows-x86_64
premerge-check-macos:
name: MacOS Premerge Checks
|
Member
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesNow that the issue-write workflow can support writing comments from Full diff: https://github.com/llvm/llvm-project/pull/170414.diff 2 Files Affected:
diff --git a/.ci/premerge_advisor_explain.py b/.ci/premerge_advisor_explain.py
index 155e91bef55f8..bd65eb3d1588b 100644
--- a/.ci/premerge_advisor_explain.py
+++ b/.ci/premerge_advisor_explain.py
@@ -129,7 +129,8 @@ def main(
# If the job succeeds and there is not an existing comment, we
# should not write one to reduce noise.
comments = []
- with open("comments", "w") as comment_file_handle:
+ comments_file_name = f"comments-{platform.system()}-{platform.machine()}"
+ with open(comments_file_name, "w") as comment_file_handle:
json.dump(comments, comment_file_handle)
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 10f7f6a827b30..4ea5397edbeac 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -124,9 +124,9 @@ jobs:
if: ${{ always() && !startsWith(matrix.runs-on, 'depot-ubuntu-24.04-arm') }}
continue-on-error: true
with:
- name: workflow-args
+ name: workflow-args-x86-linux
path: |
- comments
+ comments-Linux-x86_64
premerge-checks-windows:
name: Build and Test Windows
@@ -185,6 +185,14 @@ jobs:
path: artifacts/
retention-days: 5
include-hidden-files: 'true'
+ - name: Upload Comment
+ uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
+ if: always()
+ continue-on-error: true
+ with:
+ name: workflow-args-windows
+ path: |
+ comments-Windows-x86_64
premerge-check-macos:
name: MacOS Premerge Checks
|
cmtice
approved these changes
Dec 3, 2025
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Dec 3, 2025
Now that the issue-write workflow can support writing comments from multiple files, make the premerge workflow write out comments from both x86_64 Linux and Windows. AArch64 Linux right now is left out as the premerge advisor does not currently support it. Pull Request: llvm#170414
boomanaiden154
changed the base branch from
users/boomanaiden154/main.githubci-make-premerge-upload-results-on-linux-and-windows
to
main
boomanaiden154
deleted the
users/boomanaiden154/githubci-make-premerge-upload-results-on-linux-and-windows
branch
kcloudy0717
pushed a commit
to kcloudy0717/llvm-project
that referenced
this pull request
Dec 4, 2025
…170414) Now that the issue-write workflow can support writing comments from multiple files, make the premerge workflow write out comments from both x86_64 Linux and Windows. AArch64 Linux right now is left out as the premerge advisor does not currently support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the issue-write workflow can support writing comments from
multiple files, make the premerge workflow write out comments from both
x86_64 Linux and Windows. AArch64 Linux right now is left out as the
premerge advisor does not currently support it.