Skip to content

[lldb][windows] fix invalid corefile error message #170471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charles-zablit merged 1 commit into from
Dec 3, 2025
+6 −6
Merged

[lldb][windows] fix invalid corefile error message #170471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,10 @@ namespace lldb_private {

ProcessSP ProcessWindows::CreateInstance(lldb::TargetSP target_sp,
lldb::ListenerSP listener_sp,
const FileSpec *,
const FileSpec *crash_file_path,
bool can_connect) {
if (crash_file_path)
return nullptr; // Cannot create a Windows process from a crash_file
Copy link
Member

@JDevlieghere JDevlieghere Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return nullptr; // Cannot create a Windows process from a crash_file
return nullptr; // Cannot create a Windows process from a crash_file.

return ProcessSP(new ProcessWindows(target_sp, listener_sp));
}

Expand Down
8 changes: 3 additions & 5 deletions lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,9 @@ void ProcessGDBRemote::Terminate() {
lldb::ProcessSP ProcessGDBRemote::CreateInstance(
lldb::TargetSP target_sp, ListenerSP listener_sp,
const FileSpec *crash_file_path, bool can_connect) {
lldb::ProcessSP process_sp;
if (crash_file_path == nullptr)
process_sp = std::shared_ptr<ProcessGDBRemote>(
new ProcessGDBRemote(target_sp, listener_sp));
return process_sp;
if (crash_file_path)
return nullptr; // Cannot create a GDBRemote process from a crash_file
Copy link
Member

@JDevlieghere JDevlieghere Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return nullptr; // Cannot create a GDBRemote process from a crash_file
return nullptr; // Cannot create a GDBRemote process from a crash_file.

return lldb::ProcessSP(new ProcessGDBRemote(target_sp, listener_sp));
}

void ProcessGDBRemote::DumpPluginHistory(Stream &s) {
Expand Down
Loading