Skip to content

[DRAFT][flang] Initial change from Alexey to turn off FMF #170505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eugeneepshteyn wants to merge 6 commits into
base: main
Choose a base branch
from
+17 −2
Draft

[DRAFT][flang] Initial change from Alexey to turn off FMF #170505

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d6ed678
Initial change from Alexey to turn off FMF
eugeneepshteyn Dec 3, 2025
ee93d49
A bit of clean-up
eugeneepshteyn Dec 4, 2025
1bd268a
Merge branch 'llvm:main' into alexey-no-fmf
eugeneepshteyn Dec 4, 2025
399f4ed
Merge branch 'llvm:main' into alexey-no-fmf
eugeneepshteyn Dec 8, 2025
6b4b72c
Merge branch 'llvm:main' into alexey-no-fmf
eugeneepshteyn Dec 9, 2025
65ee341
Merge branch 'llvm:main' into alexey-no-fmf
eugeneepshteyn Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions flang/lib/Lower/ConvertExprToHLFIR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1689,12 +1689,22 @@ class HlfirBuilder {
BinaryOp<D> binaryOp;
auto left = hlfir::loadTrivialScalar(loc, builder, gen(op.left()));
auto right = hlfir::loadTrivialScalar(loc, builder, gen(op.right()));

bool noReassoc = left.template getDefiningOp<hlfir::NoReassocOp>() ||
right.template getDefiningOp<hlfir::NoReassocOp>();
llvm::SmallVector<mlir::Value, 1> typeParams;
if constexpr (R::category == Fortran::common::TypeCategory::Character) {
binaryOp.genResultTypeParams(loc, builder, left, right, typeParams);
}
if (rank == 0)
return binaryOp.gen(loc, builder, op.derived(), left, right);
if (rank == 0) {
auto fmfBackup = builder.getFastMathFlags();
if (noReassoc)
builder.setFastMathFlags(fmfBackup &
~mlir::arith::FastMathFlags::reassoc);
auto res = binaryOp.gen(loc, builder, op.derived(), left, right);
builder.setFastMathFlags(fmfBackup);
return res;
}

// Elemental expression.
mlir::Type elementType =
Expand All @@ -1721,9 +1731,14 @@ class HlfirBuilder {
// nsw is never added to operations on vector subscripts
// even if -fno-wrapv is enabled.
builder.setIntegerOverflowFlags(mlir::arith::IntegerOverflowFlags::none);
auto fmfBackup = builder.getFastMathFlags();
if (noReassoc)
builder.setFastMathFlags(fmfBackup &
~mlir::arith::FastMathFlags::reassoc);
mlir::Value elemental = hlfir::genElementalOp(loc, builder, elementType,
shape, typeParams, genKernel,
/*isUnordered=*/true);
builder.setFastMathFlags(fmfBackup);
builder.setIntegerOverflowFlags(iofBackup);
fir::FirOpBuilder *bldr = &builder;
getStmtCtx().attachCleanup(
Expand Down