Build win release packages with LLDB_ENABLE_LIBXML2

[zmodem]

Fixes #170461

[llvmbot]

@llvm/pr-subscribers-platform-windows

Author: Hans Wennborg (zmodem)

Changes

Fixes #170461

---

Full diff: https://github.com/llvm/llvm-project/pull/170513.diff

1 Files Affected:

• (modified) llvm/utils/release/build_llvm_release.bat (+2-3)

diff --git a/llvm/utils/release/build_llvm_release.bat b/llvm/utils/release/build_llvm_release.bat
index 3aeedaa3288a2..f0dc7932487b5 100644
--- a/llvm/utils/release/build_llvm_release.bat
+++ b/llvm/utils/release/build_llvm_release.bat
@@ -190,8 +190,7 @@ if "%force-msvc%" == "" (
 
 set common_lldb_flags=^
   -DLLDB_RELOCATABLE_PYTHON=1 ^
-  -DLLDB_EMBED_PYTHON_HOME=OFF ^
-  -DLLDB_ENABLE_LIBXML2=OFF
+  -DLLDB_EMBED_PYTHON_HOME=OFF
 
 set cmake_profile_flags=""
 
@@ -395,7 +394,7 @@ cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install ^
   -DLIBXML2_WITH_LZMA=OFF -DLIBXML2_WITH_MEM_DEBUG=OFF -DLIBXML2_WITH_MODULES=OFF ^
   -DLIBXML2_WITH_OUTPUT=ON -DLIBXML2_WITH_PATTERN=OFF -DLIBXML2_WITH_PROGRAMS=OFF ^
   -DLIBXML2_WITH_PUSH=OFF -DLIBXML2_WITH_PYTHON=OFF -DLIBXML2_WITH_READER=OFF ^
-  -DLIBXML2_WITH_REGEXPS=OFF -DLIBXML2_WITH_RUN_DEBUG=OFF -DLIBXML2_WITH_SAX1=OFF ^
+  -DLIBXML2_WITH_REGEXPS=OFF -DLIBXML2_WITH_RUN_DEBUG=OFF -DLIBXML2_WITH_SAX1=ON ^
   -DLIBXML2_WITH_SCHEMAS=OFF -DLIBXML2_WITH_SCHEMATRON=OFF -DLIBXML2_WITH_TESTS=OFF ^
   -DLIBXML2_WITH_THREADS=ON -DLIBXML2_WITH_THREAD_ALLOC=OFF -DLIBXML2_WITH_TREE=ON ^
   -DLIBXML2_WITH_VALID=OFF -DLIBXML2_WITH_WRITER=OFF -DLIBXML2_WITH_XINCLUDE=OFF ^

[compnerd]

It might be nice to enable this a bit further as well - llvm-rc also depends on libxml2 for manifest handling.

[zmodem]

It might be nice to enable this a bit further as well - llvm-rc also depends on libxml2 for manifest handling.

That should already be enabled:

llvm-project/llvm/utils/release/build_llvm_release.bat

Line 164 in e66e8aa

-DLLVM_ENABLE_LIBXML2=FORCE_ON ^

[omjavaid]

I am testing this on WoA will respond once done. Thanks!